WIP: Move spa_stats.c to common code

[mattmacy]

Initially it was considered simplest to stub out all
of the functions on FreeBSD. Now that FreeBSD supports
KSTAT_TYPE_RAW at least some of the functionality should
be made available.

Depends on: #10836

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[ghost]

I expect the module params at the bottom of spa_stats.c could be updated to use ZFS_MODULE_PARAM so we get them on FreeBSD, and the appropriate names added to tests/zfs-tests/include/tunables.cfg where currently undefined, too.

[codecov]

Codecov Report

Merging #10842 into master will increase coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10842      +/-   ##
==========================================
+ Coverage   79.88%   80.46%   +0.58%     
==========================================
  Files         395      293     -102     
  Lines      125066    84725   -40341     
==========================================
- Hits        99905    68176   -31729     
+ Misses      25161    16549    -8612     

Flag	Coverage Δ
#kernel	80.46% <ø> (+0.07%)	⬆️
#user	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
module/zfs/spa_stats.c	84.38% <ø> (ø)
module/icp/asm-x86_64/aes/aeskey.c	0.00% <0.00%> (-100.00%)	⬇️
module/icp/algs/modes/gcm_generic.c	11.11% <0.00%> (-88.89%)	⬇️
module/zfs/vdev_raidz_math_sse2.c	14.39% <0.00%> (-84.85%)	⬇️
module/icp/algs/aes/aes_impl_generic.c	0.82% <0.00%> (-69.55%)	⬇️
module/icp/algs/skein/skein_block.c	31.94% <0.00%> (-68.06%)	⬇️
module/icp/algs/aes/aes_impl_x86-64.c	40.00% <0.00%> (-60.00%)	⬇️
module/icp/algs/edonr/edonr.c	45.72% <0.00%> (-42.59%)	⬇️
module/zfs/ddt_zap.c	57.14% <0.00%> (-38.32%)	⬇️
module/icp/algs/modes/gcm_pclmulqdq.c	33.33% <0.00%> (-33.34%)	⬇️
... and 281 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62663fb...efbec8c. Read the comment docs.