Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dnode.h include #10819

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #10816

Description

The zfs/sa.c source file accidentally includes sys/dnode.h twice.
Remove the second occurance.

How Has This Been Tested?

Pending CI results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

The zfs/sa.c source file accidentally includes sys/dnode.h twice.
Remove the second occurance.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#10816
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Aug 26, 2020
@behlendorf behlendorf linked an issue Aug 26, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #10819 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10819      +/-   ##
==========================================
+ Coverage   79.47%   79.64%   +0.16%     
==========================================
  Files         395      395              
  Lines      125066   125066              
==========================================
+ Hits        99401    99612     +211     
+ Misses      25665    25454     -211     
Flag Coverage Δ
#kernel 80.37% <ø> (+0.06%) ⬆️
#user 65.41% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/zfs/sa.c 84.19% <ø> (+0.10%) ⬆️
module/zcommon/zfs_fletcher.c 68.09% <0.00%> (-7.57%) ⬇️
module/lua/lmem.c 83.33% <0.00%> (-4.17%) ⬇️
module/zcommon/zfs_fletcher_superscalar.c 97.05% <0.00%> (-2.95%) ⬇️
lib/libzpool/kernel.c 64.69% <0.00%> (-2.28%) ⬇️
module/icp/api/kcf_mac.c 36.57% <0.00%> (-1.72%) ⬇️
module/zcommon/zfs_fletcher_superscalar4.c 98.43% <0.00%> (-1.57%) ⬇️
module/zcommon/zfs_fletcher_sse.c 98.66% <0.00%> (-1.34%) ⬇️
lib/libzfs/libzfs_changelist.c 85.01% <0.00%> (-1.13%) ⬇️
module/os/linux/zfs/zfs_file_os.c 84.15% <0.00%> (-1.00%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbad44...34f04a9. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 27, 2020
@behlendorf behlendorf merged commit 03f5d2f into openzfs:master Aug 27, 2020
behlendorf added a commit that referenced this pull request Aug 27, 2020
The zfs/sa.c source file accidentally includes sys/dnode.h twice.
Remove the second occurrence.

Reviewed-by: Matthew Ahrens <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #10816
Closes #10819
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
The zfs/sa.c source file accidentally includes sys/dnode.h twice.
Remove the second occurrence.

Reviewed-by: Matthew Ahrens <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#10816 
Closes openzfs#10819
@behlendorf behlendorf deleted the issue-10816 branch April 19, 2021 19:22
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
The zfs/sa.c source file accidentally includes sys/dnode.h twice.
Remove the second occurrence.

Reviewed-by: Matthew Ahrens <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#10816 
Closes openzfs#10819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include twice
2 participants