Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pragma ident lines #10810

Merged
merged 1 commit into from
Aug 26, 2020
Merged

remove pragma ident lines #10810

merged 1 commit into from
Aug 26, 2020

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Aug 26, 2020 •
edited
Loading

Motivation and Context

Clean up code from unknown pragma.

Description

The #pragma ident is historical relict and not needed any more, this
pragma is actually unknown for common compilers and is only causing
trouble.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@tsoome
remove pragma ident lines
09fdd53 
The #pragma ident is historical relict and not needed any more, this
pragma is actually unknown for common compilers and is only causing
trouble.

Signed-off-by: Toomas Soome <[email protected]>
@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #10810 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10810      +/-   ##
==========================================
+ Coverage   79.43%   79.75%   +0.32%     
==========================================
  Files         395      395              
  Lines      125066   125066              
==========================================
+ Hits        99342    99748     +406     
+ Misses      25724    25318     -406
Flag Coverage Δ
#kernel 80.43% <ø> (+0.02%) ⬆️
#user 66.15% <ø> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/libzfs/os/linux/libzfs_mount_os.c 68.86% <0.00%> (-2.84%) ⬇️
lib/libzfs/libzfs_changelist.c 84.26% <0.00%> (-1.88%) ⬇️
module/zfs/metaslab.c 94.40% <0.00%> (-1.16%) ⬇️
module/os/linux/zfs/vdev_disk.c 78.85% <0.00%> (-1.08%) ⬇️
module/zfs/zio.c 87.44% <0.00%> (-1.03%) ⬇️
module/zfs/vdev_raidz.c 92.27% <0.00%> (-0.98%) ⬇️
module/icp/api/kcf_cipher.c 15.76% <0.00%> (-0.83%) ⬇️
lib/libzutil/os/linux/zutil_import_os.c 80.06% <0.00%> (-0.67%) ⬇️
module/zfs/vdev_initialize.c 97.15% <0.00%> (-0.64%) ⬇️
module/zfs/zio_checksum.c 97.75% <0.00%> (-0.57%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e129...09fdd53. Read the comment docs.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 26, 2020
@mattmacy
Copy link
Contributor

@behlendorf please pull in to 2.0 as well

@behlendorf behlendorf merged commit ec0c480 into openzfs:master Aug 26, 2020
behlendorf pushed a commit that referenced this pull request Aug 27, 2020
@tsoome @behlendorf
Remove pragma ident lines
510179f 
The #pragma ident is a historical relic and not needed any more, this
pragma is actually unknown for common compilers and is only causing
trouble.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Matt Macy <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes #10810
@tsoome tsoome deleted the ident branch August 31, 2020 07:18
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@tsoome @jsai20
Remove pragma ident lines
3e89200 
The #pragma ident is a historical relic and not needed any more, this
pragma is actually unknown for common compilers and is only causing
trouble.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Matt Macy <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes openzfs#10810
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@tsoome
Remove pragma ident lines
327c46d 
The #pragma ident is a historical relic and not needed any more, this
pragma is actually unknown for common compilers and is only causing
trouble.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Matt Macy <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes openzfs#10810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmacy mattmacy mattmacy approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsoome @mattmacy @behlendorf