FreeBSD: Don't require zeroing new locks before init

[ghost]

Signed-off-by: Ryan Moeller [email protected]

Motivation and Context

This has not shown to be of use enough to justify the inconvenience.

Description

Remove the KASSERT in FreeBSD's mutex_init. While here, change the confusing and meaningless value of MUTEX_DEFAULT to 0 instead of 6.

How Has This Been Tested?

Built on FreeBSD, did some basic testing by creating a pool, checking out ZFS sources onto the pool, and building ZFS.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[amotin]

I've never seen this assertion useful.

[codecov]

Codecov Report

Merging #10449 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10449      +/-   ##
==========================================
- Coverage   79.58%   79.42%   -0.16%     
==========================================
  Files         391      391              
  Lines      123872   123872              
==========================================
- Hits        98586    98388     -198     
- Misses      25286    25484     +198     

Flag	Coverage Δ
#kernel	79.97% <ø> (-0.06%)	⬇️
#user	65.41% <ø> (-0.71%)	⬇️

Impacted Files	Coverage Δ
module/os/linux/spl/spl-zlib.c	55.35% <0.00%> (-28.58%)	⬇️
module/zfs/vdev_indirect.c	75.00% <0.00%> (-5.67%)	⬇️
module/zfs/bpobj.c	86.86% <0.00%> (-4.29%)	⬇️
cmd/ztest/ztest.c	76.58% <0.00%> (-3.56%)	⬇️
module/zfs/zio_compress.c	89.74% <0.00%> (-2.57%)	⬇️
module/zfs/dsl_synctask.c	92.40% <0.00%> (-2.54%)	⬇️
module/zfs/dsl_scan.c	84.58% <0.00%> (-1.36%)	⬇️
module/zfs/vdev_trim.c	95.34% <0.00%> (-0.76%)	⬇️
module/zfs/vdev_removal.c	96.80% <0.00%> (-0.69%)	⬇️
module/zfs/vdev_queue.c	94.62% <0.00%> (-0.60%)	⬇️
... and 49 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08b993...f76f956. Read the comment docs.

[allanjude]

Reviewed by: [email protected]