-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure initramfs directory /usr/bin exists before attempting subsequent copy #10448
Conversation
…mpting subsequent copy Ref: initramfs hook zfsunlock creates initramfs /usr/bin as as file and not directory openzfs#10434 Modeled on the similar mkdir statement for inirtramfs /etc in the hook zfs
Codecov Report
@@ Coverage Diff @@
## master #10448 +/- ##
==========================================
- Coverage 79.58% 79.31% -0.28%
==========================================
Files 391 391
Lines 123872 123872
==========================================
- Hits 98586 98247 -339
- Misses 25286 25625 +339
Continue to review full report at Codecov.
|
@@ -15,4 +15,5 @@ esac | |||
|
|||
. /usr/share/initramfs-tools/hook-functions | |||
|
|||
mkdir -p "$DESTDIR/usr/bin/" | |||
copy_exec /usr/share/initramfs-tools/zfsunlock /usr/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy_exec calls copy_file, which has a mkdir in it. Instead of adding a mkdir, does this work:
copy_exec /usr/share/initramfs-tools/zfsunlock /usr/bin/zfsunlock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this would be better.
@IslandLife can you make suggested change to this PR so we can get it merged. |
Closing. Resolved by #11162. |
Motivation and Context
Fix for #10434 initramfs hook zfsunlock creates initramfs /usr/bin as as file and not directory
Description
Modeled on the similar mkdir statement for inirtramfs /etc in the hook zfs
How Has This Been Tested?
Types of changes
Invoke update-initramfs
Checklist:
Signed-off-by
.