Upstream: zil_commit_waiter() can stall forever #10445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS clock_t is unsigned, so when cv_timedwait_hires() returns -1 we loop forever. The conditional was tweaked to ignore signedness. Signed-off-by: Jorgen Lundman <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10445 +/- ##
==========================================
- Coverage 79.58% 79.39% -0.19%
==========================================
Files 391 391
Lines 123872 123872
==========================================
- Hits 98586 98354 -232
- Misses 25286 25518 +232
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Jun 13, 2020
ahrens
approved these changes
Jun 14, 2020
behlendorf
added
Status: Accepted
|
We don't return -1 we return the delta, so this doesn't work for FreeBSD. That would be why stable/12 failed miserably. Looks like we have a few other mistakes to fix in our condvars too, so thanks :) |
|
@freqlabs thanks for commenting. After talking with @mattmacy the plan is to get the FreeBSD condvars aligned with the other implementations as quickly as possible. |
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 19, 2020
On macOS clock_t is unsigned, so when cv_timedwait_hires() returns -1 we loop forever. The conditional was tweaked to ignore signedness. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Jorgen Lundman <[email protected]> Closes #10445
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
On macOS clock_t is unsigned, so when cv_timedwait_hires() returns -1 we loop forever. The conditional was tweaked to ignore signedness. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Jorgen Lundman <[email protected]> Closes openzfs#10445
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
On macOS clock_t is unsigned, so when cv_timedwait_hires() returns -1 we loop forever. The conditional was tweaked to ignore signedness. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Jorgen Lundman <[email protected]> Closes openzfs#10445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS clock_t is unsigned, so when cv_timedwait_hires() returns -1
we loop forever. The conditional was tweaked to ignore signedness.
Motivation and Context
Stall forever from fsync.
Description
By testing directly against -1, it does not matter if it is interpreted as signed or unsigned. Ie, no greater-than usage. Unfortunately
clock_tis defined by OS.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.