Removing ZERO_PAGE abd_alloc_zero_scatter #10428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwatkinson
referenced
this pull request
Jun 9, 2020
Adding the gang ABD type, which allows for linear and scatter ABDs to be chained together into a single ABD. This can be used to avoid doing memory copies to/from ABDs. An example of this can be found in vdev_queue.c in the vdev_queue_aggregate() function. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Co-authored-by: Brian <[email protected]> Co-authored-by: Mark Maybee <[email protected]> Signed-off-by: Brian Atkinson <[email protected]> Closes #10069
behlendorf
reviewed
Jun 9, 2020
For MIPS architectures on Linux the ZERO_PAGE macro references empty_zero_page, which is exported as a GPL symbol. The call to ZERO_PAGE in abd_alloc_zero_scatter has been removed and a single zero'd page is now allocated for each of the pages in abd_zero_scatter in the kernel ABD code path. Signed-off-by: Brian Atkinson <[email protected]>
behlendorf
approved these changes
Jun 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #10428 +/- ##
==========================================
- Coverage 79.46% 79.46% -0.01%
==========================================
Files 391 391
Lines 123632 123638 +6
==========================================
+ Hits 98245 98246 +1
- Misses 25387 25392 +5
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 12, 2020
For MIPS architectures on Linux the ZERO_PAGE macro references empty_zero_page, which is exported as a GPL symbol. The call to ZERO_PAGE in abd_alloc_zero_scatter has been removed and a single zero'd page is now allocated for each of the pages in abd_zero_scatter in the kernel ABD code path. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Brian Atkinson <[email protected]> Closes #10428
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
For MIPS architectures on Linux the ZERO_PAGE macro references empty_zero_page, which is exported as a GPL symbol. The call to ZERO_PAGE in abd_alloc_zero_scatter has been removed and a single zero'd page is now allocated for each of the pages in abd_zero_scatter in the kernel ABD code path. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Brian Atkinson <[email protected]> Closes openzfs#10428
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
For MIPS architectures on Linux the ZERO_PAGE macro references empty_zero_page, which is exported as a GPL symbol. The call to ZERO_PAGE in abd_alloc_zero_scatter has been removed and a single zero'd page is now allocated for each of the pages in abd_zero_scatter in the kernel ABD code path. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Brian Atkinson <[email protected]> Closes openzfs#10428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MIPS architectures on Linux the ZERO_PAGE macro references
empty_zero_page, which is exported as a GPL symbol. The call to
ZERO_PAGE in abd_alloc_zero_scatter has been removed and a single
zero'd page is now allocated for each of the pages in abd_zero_scatter
in the kernel ABD code path.
Signed-off-by: Brian Atkinson [email protected]
For MIPS architectures in Linux the ZERO_PAGE macro references empty_zero_page. This is a GPL only symbol.
Motivation and Context
Removes a dependency on a GPL symbol for MIPS architectures.
Description
In order to fix this, I have removed the call to ZERO_PAGE in the Linux abd_os.c for allocating the abd_zero_scatter ABD. Instead I just allocate a single page and pass the __GP_ZERO flag to zero out the page.
How Has This Been Tested?
I tested with zloop.sh (ran for 30 mins) and ZTS test.
Test on CentOS Linux kernel 4.18.5.
Types of changes
Checklist:
Signed-off-by.