Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man.8: Add bookmark to list of types. #10419

Merged
merged 1 commit into from
Jun 11, 2020
Merged

man.8: Add bookmark to list of types. #10419

merged 1 commit into from
Jun 11, 2020

Conversation

ggzengel
Copy link
Contributor

@ggzengel ggzengel commented Jun 7, 2020

Motivation and Context

While checking bash_completion I missed bookmark as type in man-pages.

# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -

Description

Add missing attribute to man page.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

While checking bash_completion I missed bookmark as type.

```
# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -
```
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #10419 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10419      +/-   ##
==========================================
+ Coverage   79.39%   79.71%   +0.32%     
==========================================
  Files         391      391              
  Lines      123633   123633              
==========================================
+ Hits        98162    98558     +396     
+ Misses      25471    25075     -396     
Flag Coverage Δ
#kernel 80.03% <ø> (+0.18%) ⬆️
#user 66.64% <ø> (+1.24%) ⬆️
Impacted Files Coverage Δ
module/zfs/vdev_indirect.c 75.00% <0.00%> (-10.00%) ⬇️
module/os/linux/zfs/vdev_file.c 80.37% <0.00%> (-1.87%) ⬇️
cmd/zed/agents/fmd_serd.c 78.21% <0.00%> (-1.00%) ⬇️
module/zfs/zfs_fm.c 84.39% <0.00%> (-0.58%) ⬇️
module/icp/api/kcf_mac.c 38.85% <0.00%> (-0.58%) ⬇️
module/zfs/bpobj.c 90.61% <0.00%> (-0.54%) ⬇️
module/zfs/txg.c 93.96% <0.00%> (-0.49%) ⬇️
module/os/linux/zfs/zpl_xattr.c 83.26% <0.00%> (-0.43%) ⬇️
module/zfs/arc.c 88.97% <0.00%> (-0.28%) ⬇️
module/os/linux/zfs/zfs_znode.c 84.93% <0.00%> (-0.23%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e319f...ec91edc. Read the comment docs.

@ahrens ahrens added the Type: Documentation Indicates a requested change to the documentation label Jun 8, 2020
@behlendorf
Copy link
Contributor

@ggzengel can you please update the PR to include your signed-off-by, then this is ready to merge.

@ggzengel
Copy link
Contributor Author

ggzengel commented Jun 9, 2020

I created this commit with github by itself. So I don't know how to edit a commit. There are no options for changing the commit description. Only the title I can change.

This and the second PR have no intellectual property because it's below the threshold of originality.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation and removed Type: Documentation Indicates a requested change to the documentation labels Jun 9, 2020
@behlendorf behlendorf merged commit 059f7c2 into openzfs:master Jun 11, 2020
lundman referenced this pull request in openzfsonosx/openzfs Jun 12, 2020
While checking bash_completion I missed bookmark as type.

```
# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -
```

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Grischa Zengel <[email protected]>
Closes #10419
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
While checking bash_completion I missed bookmark as type.

```
# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -
```

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Grischa Zengel <[email protected]>
Closes openzfs#10419 
(cherry picked from commit 059f7c2)
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
While checking bash_completion I missed bookmark as type.

```
# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -
```

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Grischa Zengel <[email protected]>
Closes openzfs#10419
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
While checking bash_completion I missed bookmark as type.

```
# zfs get type zpool2#b
NAME      PROPERTY  VALUE     SOURCE
zpool2#b  type      bookmark  -
```

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Grischa Zengel <[email protected]>
Closes openzfs#10419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants