-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
man.8: Add bookmark to list of types. #10419
Conversation
While checking bash_completion I missed bookmark as type. ``` # zfs get type zpool2#b NAME PROPERTY VALUE SOURCE zpool2#b type bookmark - ```
Codecov Report
@@ Coverage Diff @@
## master #10419 +/- ##
==========================================
+ Coverage 79.39% 79.71% +0.32%
==========================================
Files 391 391
Lines 123633 123633
==========================================
+ Hits 98162 98558 +396
+ Misses 25471 25075 -396
Continue to review full report at Codecov.
|
@ggzengel can you please update the PR to include your signed-off-by, then this is ready to merge. |
I created this commit with github by itself. So I don't know how to edit a commit. There are no options for changing the commit description. Only the title I can change. This and the second PR have no intellectual property because it's below the threshold of originality. |
While checking bash_completion I missed bookmark as type. ``` # zfs get type zpool2#b NAME PROPERTY VALUE SOURCE zpool2#b type bookmark - ``` Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Grischa Zengel <[email protected]> Closes #10419
While checking bash_completion I missed bookmark as type. ``` # zfs get type zpool2#b NAME PROPERTY VALUE SOURCE zpool2#b type bookmark - ``` Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Grischa Zengel <[email protected]> Closes openzfs#10419 (cherry picked from commit 059f7c2)
While checking bash_completion I missed bookmark as type. ``` # zfs get type zpool2#b NAME PROPERTY VALUE SOURCE zpool2#b type bookmark - ``` Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Grischa Zengel <[email protected]> Closes openzfs#10419
While checking bash_completion I missed bookmark as type. ``` # zfs get type zpool2#b NAME PROPERTY VALUE SOURCE zpool2#b type bookmark - ``` Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Grischa Zengel <[email protected]> Closes openzfs#10419
Motivation and Context
While checking bash_completion I missed bookmark as type in man-pages.
Description
Add missing attribute to man page.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.