Fix zfs_write_limit_max integer size mismatch on 32-bit systems #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2012
|
I was wrong. This does not close #831. |
Commit c409e46 introduced a number of module parameters. Of these, ARC unconditionally expected zfs_write_limit_max to be 64-bit. Unfortunately, the largest size integer module parameter that Linux supports is unsigned long, which varies in size depending on the host system's native word size. The effect was that on 32-bit systems, ARC incorrectly performed 64-bit operations on a 32-bit value by reading the neighboring 32 bits as the upper 32 bits of the 64-bit value. We correct that by changing the extern declaration to use the unsigned long type. This should make ARC correctly treat zfs_write_limit_max as a 32-bit value on 32-bit systems. Closes openzfs#749 Reported-by: Jorgen Lundman <[email protected]> Signed-off-by: Richard Yao <[email protected]>
|
Merged as commit 7df05a4. |
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Sep 26, 2023
) Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.71 to 1.0.72. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.71...1.0.72) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c409e46 introduced a number of
module parameters. Of these, ARC unconditionally expected
zfs_write_limit_max to be 64-bit. Unfortunately, the largest size
integer module parameter that Linux supports is unsigned
long, which varies in size depending on the host system's native word
size. The effect was that on 32-bit systems, ARC incorrectly performed
64-bit operations on a 32-bit value by reading the neighboring 32 bits
as the upper 32 bits of the 64-bit value. We correct that by changing
the extern declaration to use the unsigned long type. This should make
ARC correctly treat zfs_write_limit_max as a 32-bit value on 32-bit
systems.
Closes #749
Reported-by: Jorgen Lundman [email protected]
Signed-off-by: Richard Yao [email protected]