Don't attempt trimming "hole" vdevs #10227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On zpools containig hole vdevs (e.g. removed log devices), the `zpool trim` (and presumably `zpool initialize`) commands will attempt calling their respective functions on "hole", which fails, as this is not a real vdev. Avoid this by removing HOLE vdevs in zpool_collect_leaves. Signed-off-by: Niklas Haas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10227 +/- ##
==========================================
- Coverage 79.48% 79.25% -0.24%
==========================================
Files 388 388
Lines 123390 123391 +1
==========================================
- Hits 98077 97791 -286
- Misses 25313 25600 +287
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Apr 20, 2020
gmelikov
approved these changes
Apr 21, 2020
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
On zpools containing hole vdevs (e.g. removed log devices), the `zpool trim` (and presumably `zpool initialize`) commands will attempt calling their respective functions on "hole", which fails, as this is not a real vdev. Avoid this by removing HOLE vdevs in zpool_collect_leaves. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Niklas Haas <[email protected]> Closes openzfs#10227 (cherry picked from commit a84c92f)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
On zpools containing hole vdevs (e.g. removed log devices), the `zpool trim` (and presumably `zpool initialize`) commands will attempt calling their respective functions on "hole", which fails, as this is not a real vdev. Avoid this by removing HOLE vdevs in zpool_collect_leaves. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Niklas Haas <[email protected]> Closes openzfs#10227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I noticed that my
zpool trim <poolname>command fails with:I've never seen such
"hole"devices before, but I suspect the reason I have one now was that I added and removed a log device for testing purposes. (One of the commends inzpool_vdev.csuggests something similar: that"hole"represents added and removed aux devices)Obviously a command like
zpool trimshould therefore ignore hole devices.Description
The easiest place to make this change is in
zpool_collect_leaves. This has only one other user (zpool initialize), which I therefore assume has the same bug.How Has This Been Tested?
I rebuilt
zpooland ranzpool trimon my pool, which worked successfully. I have not tested the effects of the change onzpool initialize.Types of changes
Checklist:
Signed-off-by.