Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SC2086 note in zpool.d/smart #10194

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2020

Motivation and Context

./cmd/zpool/zpool.d/smart:78:32:
note: Double quote to prevent globbing and word splitting. [SC2086]

Reported by latest shellcheck on FreeBSD.

Description

Add missing quotes around a variable usage in zpool.d/smart.

How Has This Been Tested?

gmake shellcheck with hs-ShellCheck-0.7.1 on FreeBSD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

./cmd/zpool/zpool.d/smart:78:32:
note: Double quote to prevent globbing and word splitting. [SC2086]

Reported by latest shellcheck on FreeBSD.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Apr 11, 2020
@ghost ghost requested a review from tonyhutter April 11, 2020 08:03
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #10194 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10194      +/-   ##
==========================================
- Coverage   79.48%   79.23%   -0.26%     
==========================================
  Files         387      387              
  Lines      123388   123388              
==========================================
- Hits        98079    97762     -317     
- Misses      25309    25626     +317     
Flag Coverage Δ
#kernel 79.86% <ø> (-0.11%) ⬇️
#user 65.41% <ø> (-0.70%) ⬇️
Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 75.22% <0.00%> (-9.59%) ⬇️
module/zfs/vdev_indirect.c 75.00% <0.00%> (-9.00%) ⬇️
module/zfs/space_map.c 93.06% <0.00%> (-5.20%) ⬇️
cmd/ztest/ztest.c 76.36% <0.00%> (-4.43%) ⬇️
module/zfs/spa_checkpoint.c 93.78% <0.00%> (-4.35%) ⬇️
module/lua/lmem.c 83.33% <0.00%> (-4.17%) ⬇️
module/zfs/zio_compress.c 89.74% <0.00%> (-2.57%) ⬇️
module/zfs/dsl_synctask.c 92.40% <0.00%> (-2.54%) ⬇️
module/os/linux/zfs/vdev_file.c 80.37% <0.00%> (-1.87%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f2878...f4374e3. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Apr 14, 2020
@behlendorf behlendorf merged commit 813c856 into openzfs:master Apr 14, 2020
@ghost ghost deleted the sh-smart branch April 14, 2020 20:19
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
./cmd/zpool/zpool.d/smart:78:32:
note: Double quote to prevent globbing and word splitting. [SC2086]

Reported by latest shellcheck on FreeBSD.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10194 
(cherry picked from commit 813c856)
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
./cmd/zpool/zpool.d/smart:78:32:
note: Double quote to prevent globbing and word splitting. [SC2086]

Reported by latest shellcheck on FreeBSD.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants