Fix allocation error, detected using ASAN #10193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to add this. Configuration: Error messages (somewhat edited): |
Signed-off-by: João Carlos Mendes Luis <[email protected]>
ahrens
approved these changes
Apr 11, 2020
|
Thanks for noticing this! |
behlendorf
approved these changes
Apr 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #10193 +/- ##
==========================================
- Coverage 79.30% 79.21% -0.10%
==========================================
Files 387 387
Lines 123387 123388 +1
==========================================
- Hits 97858 97739 -119
- Misses 25529 25649 +120
Continue to review full report at Codecov.
|
The test for VDEV_TYPE_INDIRECT is done after a memory allocation, and could return from function without freeing it. Since we don't need that alocation yet, just postpone it. Signed-off-by: João Carlos Mendes Luís <[email protected]>
|
I'm new to this merge and update method from github, sorry if I did something wrong. Just added another leak fix, at f22b88f Error appears at |
ahrens
approved these changes
Apr 12, 2020
behlendorf
approved these changes
Apr 13, 2020
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
The test for VDEV_TYPE_INDIRECT is done after a memory allocation, and could return from function without freeing it. Since we don't need that allocation yet, just postpone it. Add a missing free() when buffer is no longer needed. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: João Carlos Mendes Luís <[email protected]> Closes openzfs#10193 (cherry picked from commit 75c6201)
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
The test for VDEV_TYPE_INDIRECT is done after a memory allocation, and could return from function without freeing it. Since we don't need that allocation yet, just postpone it. Add a missing free() when buffer is no longer needed. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: João Carlos Mendes Luís <[email protected]> Closes openzfs#10193 (cherry picked from commit 75c6201)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The test for VDEV_TYPE_INDIRECT is done after a memory allocation, and could return from function without freeing it. Since we don't need that allocation yet, just postpone it. Add a missing free() when buffer is no longer needed. Reviewed-by: Matthew Ahrens <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: João Carlos Mendes Luís <[email protected]> Closes openzfs#10193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I just found an ASAN warning in zpool cmd
Apparently it only turns on when a pool has some removed vdev data.
Description
Just add the
free()when buffer is no more needed.How Has This Been Tested?
Compiled in my home setup, ran, and error is gone
Types of changes
Checklist:
Signed-off-by.