zts: Fix and change testcase cache_010_neg #10172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaghetti-
commented
Apr 2, 2020
spaghetti-
commented
Apr 2, 2020
behlendorf
added
Status: Code Review Needed
behlendorf
reviewed
Apr 2, 2020
ghost
suggested changes
Apr 2, 2020
behlendorf
added
Status: Work in Progress
spaghetti-
force-pushed
the
fix-cache-010-test
branch
from
62abe68 to
c88e3c5
Compare
ghost
suggested changes
Apr 10, 2020
spaghetti-
force-pushed
the
fix-cache-010-test
branch
from
c88e3c5 to
c7fbde0
Compare
Codecov Report
@@ Coverage Diff @@
## master #10172 +/- ##
==========================================
- Coverage 79.40% 79.17% -0.23%
==========================================
Files 385 385
Lines 122603 122603
==========================================
- Hits 97350 97073 -277
- Misses 25253 25530 +277
Continue to review full report at Codecov.
|
behlendorf
reviewed
Apr 10, 2020
spaghetti-
force-pushed
the
fix-cache-010-test
branch
2 times, most recently
from
ab35b26 to
ebfe93d
Compare
Commit 379ca9c removed the requirement on aux devices to be block devices only but the test case cache_010_neg was not updated, making it fail consistently. This change changes the test to check that cache devices _can_ be anything that presents a block interface. The testcase is renamed to cache_010_pos and the exceptions for known failure removed from the test runner. Reported-by: Richard Elling <[email protected]> Signed-off-by: Alex John <[email protected]>
ghost
approved these changes
Apr 11, 2020
spaghetti-
changed the title
behlendorf
approved these changes
Apr 13, 2020
behlendorf
added
Status: Accepted
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
Commit 379ca9c removed the requirement on aux devices to be block devices only but the test case cache_010_neg was not updated, making it fail consistently. This change changes the test to check that cache devices _can_ be anything that presents a block interface. The testcase is renamed to cache_010_pos and the exceptions for known failure removed from the test runner. Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reported-by: Richard Elling <[email protected]> Signed-off-by: Alex John <[email protected]> Closes openzfs#10172 (cherry picked from commit c602b35)
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Commit 379ca9c removed the requirement on aux devices to be block devices only but the test case cache_010_neg was not updated, making it fail consistently. This change changes the test to check that cache devices _can_ be anything that presents a block interface. The testcase is renamed to cache_010_pos and the exceptions for known failure removed from the test runner. Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reported-by: Richard Elling <[email protected]> Signed-off-by: Alex John <[email protected]> Closes openzfs#10172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Commit 379ca9c removed the requirement on aux devices to be block
devices only but the test case cache_010_neg was not updated, making it
fail consistently.
WIP to get comments from maintainers and other contributors.
Description
This change changes the test to check that cache devices can be files
and character devices too. The testcase is renamed to cache_010_pos and
the exceptions for known failure removed from the test runner.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.