Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc_summary: Make get_descriptions per platform #10062

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2020

Motivation and Context

Linux uses modinfo to get tunables descriptions, FreeBSD has to use sysctl.

Description

Move the existing function definition so it is defined that way on Linux, and add a definition in terms of sysctl for FreeBSD.

How Has This Been Tested?

The arc_summary_* tests pass on FreeBSD now.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Linux uses modinfo to get tunables descriptions, FreeBSD has to use
sysctl.

Move the existing function definition so it is defined that way on
Linux, and add a definition in terms of sysctl for FreeBSD.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Feb 26, 2020
@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #10062 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #10062    +/-   ##
========================================
+ Coverage      79%      80%   +<1%     
========================================
  Files         386      386            
  Lines      122303   122303            
========================================
+ Hits        96985    97301   +316     
+ Misses      25318    25002   -316
Flag Coverage Δ
#kernel 80% <ø> (ø) ⬆️
#user 67% <ø> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abef699...fb8e9f9. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 27, 2020
@behlendorf behlendorf merged commit 2ce90dc into openzfs:master Feb 28, 2020
@ghost ghost deleted the arc_summary-descr branch February 28, 2020 01:41
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Linux uses modinfo to get tunables descriptions, FreeBSD has to use
sysctl.

Move the existing function definition so it is defined that way on
Linux, and add a definition in terms of sysctl for FreeBSD.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants