zfs-load-key-<pool>.service asks for passphrase when the key is already loaded #9495
Comments
behlendorf
added
Component: Encryption
|
Let's see if we can get @aerusso, @tcaputi, @rlaager's thoughts on this. My initial inclination would be to update the |
It seems checking that Making |
|
@vozhyk- You need a single "=" in that code. "==" is a bash-ism. |
|
I haven't thought about this much, but it seems to me that checking the That said, if we want to make |
|
@rlaager Thanks for the review! Fixed. I've tested this change on the Sabayon system with the root pool and with the reproducer commands, and the service works as it should now. I'll open a PR later today. |
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. Closes openzfs#9495 Signed-off-by: Witaut Bajaryn <[email protected]>
|
This problem also exists in dracut module in the mount-zfs.sh. There should be a check included to see if zfs encryption key was already loaded. |
The user might have loaded the key manually or by other means before the scripts get called. Issue openzfs#9495
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. Closes openzfs#9495 Signed-off-by: Witaut Bajaryn <[email protected]>
The user might have loaded the key manually or by other means before the scripts get called. Issue openzfs#9495 Signed-off-by: Witaut Bajaryn <[email protected]>
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. The user might have loaded the key manually or by other means before the scripts get called. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tom Caputi <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Witaut Bajaryn <[email protected]> Closes #9495 Closes #9529
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. The user might have loaded the key manually or by other means before the scripts get called. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tom Caputi <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Witaut Bajaryn <[email protected]> Closes openzfs#9495 Closes openzfs#9529
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. The user might have loaded the key manually or by other means before the scripts get called. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tom Caputi <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Witaut Bajaryn <[email protected]> Closes openzfs#9495 Closes openzfs#9529
Don't ask for the password / try to load the key if the key for the encryptionroot is already loaded. The user might have loaded the key manually or by other means before the scripts get called. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tom Caputi <[email protected]> Reviewed-by: Richard Laager <[email protected]> Signed-off-by: Witaut Bajaryn <[email protected]> Closes #9495 Closes #9529
System information
Describe the problem you're observing
genkernelfrom https://gitlab.com/linux-be/genkernel) loads the key for my root pool (te) and mounts the boot environment's datasets.zfs-load-key-te.service(generated byzfs-mount-generator) asks for the passphrase again, even though the key is already loaded.Describe how to reproduce the problem
This can be reproduced with a pool on a file as well:
The text was updated successfully, but these errors were encountered: