SPL/ZFS compiler warnings on 32-bit systems

[adilger]

There are a number of compiler warnings on i686 that are in the build log:
http://build.whamcloud.com/job/lustre-reviews/7484/arch=i686,build_type=server,distro=el6,ib_stack=inkernel/consoleFull

spl-0.6.0/module/spl/spl-generic.c:490: warning: format '%lu' expects type 'long unsigned int', but argument 4 has type 'unsigned int'
warning: File listed twice: /etc/zfs/zdev.conf
warning: File listed twice: /lib/udev/rules.d
warning: File listed twice: /lib/udev/rules.d/60-vdev.rules
warning: File listed twice: /lib/udev/rules.d/60-zpool.rules
warning: File listed twice: /lib/udev/rules.d/60-zvol.rules
warning: File listed twice: /lib/udev/rules.d/90-zfs.rules
warning: File listed twice: /lib/udev/vdev_id
warning: File listed twice: /lib/udev/zpool_id
warning: File listed twice: /lib/udev/zvol_id
In function 'zfsctl_is_snapdir':
zfs-0.6.0//module/zfs/zfs_ctldir.c:151: warning: integer constant is too large for 'long' type
In function 'zfsctl_create':
zfs-0.6.0/module/zfs/zfs_ctldir.c:276: warning: integer constant is too large for 'long' type
In function 'zfsctl_root_lookup':
zfs-0.6.0/module/zfs/zfs_ctldir.c:401: warning: integer constant is too large for 'long' type
zfs-0.6.0/module/zfs/zfs_ctldir.c:402: warning: large integer implicitly truncated to unsigned type
zfs-0.6.0/module/zfs/zfs_ctldir.c:404: warning: integer constant is too large for 'long' type
zfs-0.6.0/module/zfs/zfs_ctldir.c:405: warning: large integer implicitly truncated to unsigned type
In function 'zfsctl_snapdir_lookup':
zfs-0.6.0/module/zfs/zfs_ctldir.c:440: warning: integer constant is too large for 'long' type
In function 'zpl_root_readdir':
zfs-0.6.0/module/zfs/zpl_ctldir.c:108: warning: integer constant is too large for 'long' type
zfs-0.6.0/module/zfs/zpl_ctldir.c:116: warning: integer constant is too large for 'long' type
In function 'zpl_snapdir_readdir':
zfs-0.6.0/module/zfs/zpl_ctldir.c:256: warning: integer constant is too large for 'long' type

[ryao]

Thanks for reporting this. This could explain some of the issues that people are having on 32-bit systems.

[behlendorf]

I really should add an x86 builder to my build farm to catch these sorts of things. Yes, we'll need to run them down.

[ryao]

The issue here appears to be that some constants in ./include/sys/zfs_ctldir.h were changed from 0x1, 0x2 0x3... to 0x0000FFFFFFFFFFFF, 0x0000FFFFFFFFFFFE, 0x0000FFFFFFFFFFFD and the compiler does not like that. Using the ULL suffix should fix that. I will file a pull request with that change after testing it for regressions on amd64.