Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case: casenorm test group #7633

Open
behlendorf opened this issue Jun 14, 2018 · 5 comments · Fixed by #8812
Open

Test case: casenorm test group #7633

behlendorf opened this issue Jun 14, 2018 · 5 comments · Fixed by #8812
Labels
Bot: Not Stale Override for the stale bot Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@behlendorf
Copy link
Contributor

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version zfs-0.7.0-1601
SPL Version n/a

Describe the problem you're observing

Several of the case normalization test cases need to updated for Linux. This may also involve some code changes to ensure this functionality is fully integrated with the Linux kernel.

casenorm/sensitive_none_lookup
casenorm/sensitive_none_delete
casenorm/sensitive_formd_lookup
casenorm/sensitive_formd_delete
casenorm/insensitive_none_lookup
casenorm/insensitive_none_delete
casenorm/insensitive_formd_lookup
casenorm/insensitive_formd_delete
casenorm/mixed_none_lookup
casenorm/mixed_none_lookup_ci
casenorm/mixed_none_delete
casenorm/mixed_formd_lookup
casenorm/mixed_formd_lookup_ci
casenorm/mixed_formd_delete

Describe how to reproduce the problem

./scripts/zfs-tests.sh -v -T casenorm

@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Jun 14, 2018
@tonyhutter
Copy link
Contributor

tonyhutter commented Oct 9, 2018

This failure is still present as of today (5e8ff25).

I see that sensitive_none_lookup.ksh and others call lookup_file in casenorm.kshlib, which in turn calls zlook -l $TESTDIR $name >/dev/null 2>&1, but zlook doesn't exist in ZoL.

From illumos zlook.c:

/*
 * This is a test program that uses ioctls to the ZFS Unit Test driver
 * to perform readdirs or lookups using flags not normally available
 * to user-land programs.  This allows testing of the flags'
 * behavior outside of a complicated consumer, such as the SMB driver.
 */

Looks like it does two ioctls:

                        if ((ierr = ioctl(fd, ZUT_IOC_READDIR, &rd)) != 0) {
...
                if ((ierr = ioctl(fd, ZUT_IOC_LOOKUP, &lk)) != 0) {

A quick search doesn't show either of these ioctls in ZoL.

@behlendorf
Copy link
Contributor Author

As I understand it zlook depends on the illumos zut (ZFS Unit Test) filesystem driver filesystem driver. This was never ported to Linux since only these test cases depended on it. The intention was to either rewrite these tests in a way which doesn't require this driver, or alternately extend the ZFS kernel module with the needed ioctls and update zlook accordingly. It'd definitely be nice to get test test group running.

@ikozhukhov
Copy link
Contributor

ikozhukhov commented May 13, 2019

more info: tests are PASS with illumos ksh version and failed with Debian ksh version on DilOS
it's mean - tests are depend on KSH version.
I tried to use BASH instead of KSH and tests are failed too.
will try investigate why tests are PASS with illumos KSH.

@ikozhukhov
Copy link
Contributor

info: i have updated tests to use echo -e on DilOS with ksh version from Debian and all these tests are PASS.
probably need a try updates tests to use printf

behlendorf pushed a commit that referenced this issue Nov 20, 2019
Use `printf` to properly interpret unicode characters.

Illumos uses a utility called `zlook` to allow additional flags to be 
provided to readdir and lookup for testing.  This functionality could 
be ported to Linux, but even without it several of the tests can be 
enabled by instead using the standard `test` command.

Additional, work is required to enable the remaining test cases.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Issue #7633 
Closes #8812
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Dec 26, 2019
Use `printf` to properly interpret unicode characters.

Illumos uses a utility called `zlook` to allow additional flags to be
provided to readdir and lookup for testing.  This functionality could
be ported to Linux, but even without it several of the tests can be
enabled by instead using the standard `test` command.

Additional, work is required to enable the remaining test cases.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Issue openzfs#7633
Closes openzfs#8812
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Dec 27, 2019
Use `printf` to properly interpret unicode characters.

Illumos uses a utility called `zlook` to allow additional flags to be
provided to readdir and lookup for testing.  This functionality could
be ported to Linux, but even without it several of the tests can be
enabled by instead using the standard `test` command.

Additional, work is required to enable the remaining test cases.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Issue openzfs#7633
Closes openzfs#8812
tonyhutter pushed a commit that referenced this issue Jan 23, 2020
Use `printf` to properly interpret unicode characters.

Illumos uses a utility called `zlook` to allow additional flags to be
provided to readdir and lookup for testing.  This functionality could
be ported to Linux, but even without it several of the tests can be
enabled by instead using the standard `test` command.

Additional, work is required to enable the remaining test cases.

Reviewed-by: Igor Kozhukhov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Issue #7633
Closes #8812
@gmelikov gmelikov reopened this Jan 29, 2021
@stale
Copy link

stale bot commented Jan 29, 2022

This issue has been automatically marked as "stale" because it has not had any activity for a while. It will be closed in 90 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale No recent activity for issue label Jan 29, 2022
@behlendorf behlendorf added Bot: Not Stale Override for the stale bot and removed Status: Stale No recent activity for issue labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot: Not Stale Override for the stale bot Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants