-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QAT compression always fails to take effect #7081
Comments
@woquflux can you please let us know the steps how to reproduce this issue? E.g., OS info, file type, size etc. you are using for testing? The code runs well on our system, so need more info to reproduce it. |
OK! Thank you for answering my question! |
System Message
Here is my detailed steps
|
@woquflux thanks for the steps, we can reproduce this problem now. First looking at this issue it seems you are using "dd" to copy block device to another disk which source buffer is probably not allocated by file-system, we need investigate more details to work out a fix. In the meanwhile, you can change your test method e.g., copy files from a file-system directory to the Zpool, or use FIO for the tests. If you want to use dd test from block layer, please try to remove the check in line 373 in file qat_compress.c, and re-build ZFS module. This condition check should be removed, but we need more tests to verify it before we submit a new PR. |
@wli5 Thank you for this information,but I already try copy files to zfs volume to test this, the result is same as dd. At the same time, I also try to remove the check in line 373 in file qat_compress.c, looks normal at first, but after some time, I found zfs volume and the system volume has a problem, I will re-test later and give you a detailed description of this phenomenon. |
@woquflux by removing this condition check we've verified the code works well, please provide more info if you still find a problem, thanks! |
@wli5 Sorry, I just found my test method have a little problem, so I will retest by removing condition check, I believe it should be no problem. Thank you very much! |
@wli5 I found a new problem, When I install qat driver, if I choose Sr-iov (Host), I found the qat is fails to take effect too, Then I check the code, I find this exit in qat_compress.c at line 209, This means system have not avaliable DC instance, so what is the reason?
Are you Chinese? Can you give me your phone number or other ways of contact? The following are the details
|
@woquflux are you using zfs+qat in your VM or host? have you tested the kernel space sample code, can you see instance in the sample code? Yes, I'm in China, we can talk. |
@wli5 I did not use a virtual machine, I opened the IOMMU, so I found that you need to select Sr-iov (host) when installing the driver, so Can you give me your WeChat, My WeChat is he_dong_zhang, I elaborate on my test method. |
This fix is for issue openzfs#7081: Remove the unused vmalloc address check, and function mem_to_page will handle the non-vmalloc address when map it to a physical address.
This fix is for issue openzfs#7081: Remove the unused vmalloc address check, and function mem_to_page will handle the non-vmalloc address when map it to a physical address. Signed-off-by: Weigang Li <[email protected]>
System information
Describe the problem you're observing
I follow the link(#5846) to test my QAT to compress zfs volume,But it always does not work
The following is the QAT statistics when I use dd or cp to write data to the zfs volume
So I looked qat_compress.c code, then I find code always return from this location:
The same result when I try to use the zfs 0.7.0 version,So why is this problem, how can I continue my test ?
Other Message
This is the status of QAT
This is the status of zfs
The text was updated successfully, but these errors were encountered: