zfs_dirty_data_max_max grows without bound as memory is installed #6072
Comments
behlendorf
added a commit
to behlendorf/zfs
that referenced
this issue
Apr 28, 2017
Reinstate default 4G zfs_dirty_data_max_max limit. Signed-off-by: Brian Behlendorf <[email protected]> Issue openzfs#6072
12 tasks
|
@evujumenuk thanks for reminding us about this. Yes, this was an oversight and we should reinstate it which I've done in PR #6081. @tuxoko I believe you ran in to trouble with this when testing on a large memory machine, if you could review this that'd be great. |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this issue
May 26, 2017
Reinstate default 4G zfs_dirty_data_max_max limit. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Chunwei Chen <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#6072 Closes openzfs#6081
tonyhutter
pushed a commit
that referenced
this issue
Jun 9, 2017
Reinstate default 4G zfs_dirty_data_max_max limit. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Chunwei Chen <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #6072 Closes #6081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #1696 (comment),
zfs_dirty_data_max_maxis dynamically set to a fraction ofphysmem * PAGESIZEwhere it used to be statically set to 4 GiB. As the comment notes, this change was intended to prevent overflow ofzfs_dirty_data_maxandzfs_dirty_data_max_maxon 32-bit systems.It's clear that these values need to shrink on 32-bit systems.
It's not clear that these values would need to grow on large 64-bit systems.
Ideally,
zfs_dirty_data_max_maxwould be capped to 4 GB (as it was before).The text was updated successfully, but these errors were encountered: