Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case: zfs_rename_009_neg #5648

Closed
behlendorf opened this issue Jan 24, 2017 · 0 comments
Closed

Test case: zfs_rename_009_neg #5648

behlendorf opened this issue Jan 24, 2017 · 0 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@behlendorf
Copy link
Contributor

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version 0.7.0-rc3
SPL Version 0.7.0-rc3

Describe the problem you're observing

Rarely observed failure of zfs_rename_009_neg during automated testing.

Describe how to reproduce the problem

Reproducible by the buildbot.

Include any warning/errors/backtraces from the system logs

http://build.zfsonlinux.org/builders/Amazon%202015.09%20x86_64%20Release%20%28TEST%29/builds/1057/steps/shell_11/logs/log

Test: /usr/share/zfs/zfs-tests/tests/functional/cli_root/zfs_rename/zfs_rename_009_neg (run as root) [00:00] [FAIL]
01:19:34.49 ASSERTION: zfs rename -r failed, when snapshot name is already existing.
01:19:34.52 SUCCESS: /sbin/zfs snapshot -r testpool.24870@snap
01:19:34.53 SUCCESS: /sbin/zfs snapshot testpool.24870@snap2
01:19:34.54 SUCCESS: /sbin/zfs rename -r testpool.24870@snap testpool.24870@snap2 exited 1
01:19:34.55 SUCCESS: /sbin/zfs destroy testpool.24870@snap2
01:19:34.56 SUCCESS: /sbin/zfs snapshot testpool.24870/testctr24870@snap2
01:19:34.57 SUCCESS: /sbin/zfs rename -r testpool.24870@snap testpool.24870@snap2 exited 1
01:19:34.59 SUCCESS: /sbin/zfs destroy testpool.24870/testctr24870@snap2
01:19:34.60 SUCCESS: /sbin/zfs snapshot testpool.24870/testctr24870/testfs1.24870@snap2
01:19:34.61 SUCCESS: /sbin/zfs rename -r testpool.24870@snap testpool.24870@snap2 exited 1
01:19:34.62 SUCCESS: /sbin/zfs destroy testpool.24870/testctr24870/testfs1.24870@snap2
01:19:34.64 SUCCESS: /sbin/zfs snapshot testpool.24870/testfs.24870@snap2
01:19:34.64 SUCCESS: /sbin/zfs rename -r testpool.24870@snap testpool.24870@snap2 exited 1
01:19:34.65 SUCCESS: /sbin/zfs destroy testpool.24870/testfs.24870@snap2
01:19:34.67 SUCCESS: /sbin/zfs snapshot testpool.24870/testvol24870@snap2
01:19:34.67 SUCCESS: /sbin/zfs rename -r testpool.24870@snap testpool.24870@snap2 exited 1
01:19:34.69 SUCCESS: /sbin/zfs destroy testpool.24870/testvol24870@snap2
01:19:34.69 NOTE: Performing local cleanup via log_onexit (cleanup)
01:19:34.73 SUCCESS: /sbin/zfs destroy testpool.24870@snap
01:19:34.75 SUCCESS: /sbin/zfs destroy testpool.24870/datafs.rename@snap
01:19:34.76 SUCCESS: /sbin/zfs destroy testpool.24870/testctr124870@snap
01:19:34.78 SUCCESS: /sbin/zfs destroy testpool.24870/testctr24870@snap
01:19:34.79 SUCCESS: /sbin/zfs destroy testpool.24870/testctr24870/testfs1.24870@snap
01:19:34.81 SUCCESS: /sbin/zfs destroy testpool.24870/testfs.24870@snap
01:19:34.82 SUCCESS: /sbin/zfs destroy testpool.24870/testfs1.24870@snap
01:19:34.83 SUCCESS: /sbin/zfs destroy testpool.24870/testsnap24870_clone@snap
01:19:34.84 cannot destroy 'testpool.24870/testvol24870@testsnap24870': snapshot has dependent clones use '-R' to destroy the following datasets: testpool.24870/testsnap24870_clone
01:19:34.84 ERROR: /sbin/zfs destroy testpool.24870/testvol24870@testsnap24870 exited 1
@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Jan 24, 2017
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 24, 2017
@behlendorf
Refresh Linux test suite runfile
68edecf 
Associate disabled test cases with existing open issues, update
update comments to be consistent and disable a few test cases.
The goal is for all enabled test to pass reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf mentioned this issue Jan 24, 2017
Merged
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 24, 2017
@behlendorf
Refresh Linux test suite runfile
a9e171e 
Associate disabled test cases with existing open issues, update
comments to be consistent and disable a few additional test cases.
The goal is for all enabled test to pass reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654

Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 25, 2017
@behlendorf
Refresh Linux test suite runfile
3e721e3 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654
- history_006_neg     - openzfs#5657
- history_008_pos     - openzfs#5658

Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 25, 2017
@behlendorf
Refresh Linux test suite runfile
49bcbdb 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654
- rsend_024_pos       - openzfs#5665
- history_008_pos     - openzfs#5658
- history_006_neg     - openzfs#5657
- history_008_pos     - openzfs#5658

Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf added a commit to behlendorf/zfs that referenced this issue Jan 26, 2017
@behlendorf
Refresh Linux test suite runfile
0a209ca 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654
- rsend_024_pos       - openzfs#5665
- history_008_pos     - openzfs#5658
- history_006_neg     - openzfs#5657
- history_008_pos     - openzfs#5658
- zfs_inherit_003_pos - openzfs#5669

Signed-off-by: Brian Behlendorf <[email protected]>
behlendorf added a commit that referenced this issue Jan 26, 2017
@behlendorf
Refresh Linux test suite runfile
f925de3 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - #5635
- zfs_rename_006_pos  - #5647
- zfs_rename_009_neg  - #5648
- zpool_clear_001_pos - #5634
- zfs_allow_010_pos   - #5646
- reservation_018_pos - #5642
- snapused_004_pos    - #5513
- rsend_022_pos       - #5654
- rsend_024_pos       - #5665
- history_008_pos     - #5658
- history_006_neg     - #5657
- history_008_pos     - #5658
- zfs_inherit_003_pos - #5669

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #5649
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@behlendorf @wli5
Refresh Linux test suite runfile
4d38f3d 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654
- rsend_024_pos       - openzfs#5665
- history_008_pos     - openzfs#5658
- history_006_neg     - openzfs#5657
- history_008_pos     - openzfs#5658
- zfs_inherit_003_pos - openzfs#5669

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#5649
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@behlendorf @wli5
Refresh Linux test suite runfile
af1a9f0 
Associate disabled test cases with existing open issues, update
comments to be consistent, disable a few additional test cases.
The goal is for all enabled test to pass 100% reliably.

The following test cases have been disabled due to infrequent
failures during automated testing.  Several of these test cases
were previous disabled only for the kmemleak builder but have
subsequently been observed on other automated builders.

- zfs_destroy_001_pos - openzfs#5635
- zfs_rename_006_pos  - openzfs#5647
- zfs_rename_009_neg  - openzfs#5648
- zpool_clear_001_pos - openzfs#5634
- zfs_allow_010_pos   - openzfs#5646
- reservation_018_pos - openzfs#5642
- snapused_004_pos    - openzfs#5513
- rsend_022_pos       - openzfs#5654
- rsend_024_pos       - openzfs#5665
- history_008_pos     - openzfs#5658
- history_006_neg     - openzfs#5657
- history_008_pos     - openzfs#5658
- zfs_inherit_003_pos - openzfs#5669

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#5649
GregorKopka pushed a commit to GregorKopka/zfs that referenced this issue Jan 7, 2019
ZTS: Fix and reenable zfs_rename tests
bb59844 
zfs_rename_006_pos has been flaky in the past because it was
missing a call to block_device_wait to ensure the zvols it creates
are present before running dd. Whenever this this happened,
zfs_rename_009_neg would also fail because the first test would
leak a zvol clone that it did not know how to clean up. This patch
fixes the root cause and reenables the test. It also fixes some
minor grammar errors.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tom Caputi <[email protected]>
Closes openzfs#5647 
Closes openzfs#5648 
Closes openzfs#8088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behlendorf