Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elevator "none" check is reverses, regression from commit d1d7e2689db9e ("cstyle: Resolve C style issues") #4507

Closed
ColinIanKing opened this issue Apr 11, 2016 · 4 comments
Closed

elevator "none" check is reverses, regression from commit d1d7e2689db9e ("cstyle: Resolve C style issues") #4507

ColinIanKing opened this issue Apr 11, 2016 · 4 comments
Milestone
0.6.5.7

Comments

@ColinIanKing
Copy link
Contributor

Commit commit d1d7e26 ("cstyle: Resolve C style issues") while cleaning up style warnings broke the none elevator comparison in module/zfs/vdev_disk.c, vdev_elevator_switch():

  •   if (!strncmp(elevator, "none", 4) && (strlen(elevator) == 4))

  •   if (strncmp(elevator, "none", 4) && (strlen(elevator) == 4) == 0)

The code no longer returns 0 when elevator == "none".
@behlendorf
Copy link
Contributor

Indeed it did. Please open a PR to revert this change in a fashion make cstyle is happy with so we can resolve this.

@ColinIanKing
Copy link
Contributor Author

I'm unfamiliar with the process here, not sure what you mean by "open a PR".

@drescherjm
Copy link

PR = Pull Request.

@behlendorf
Copy link
Contributor

Github shorthand for a pull request. If you can create a new one with a tiny fix for this it'll be easy to get it reviewed, merged, and attributed properly.

@ColinIanKing ColinIanKing mentioned this issue Apr 14, 2016
Closed
@behlendorf behlendorf added this to the 0.6.5.7 milestone Apr 15, 2016
nedbass pushed a commit to nedbass/zfs that referenced this issue May 6, 2016
@nedbass
Fix inverted logic on none elevator comparison
60a4ea3 
Commit d1d7e26 ("cstyle: Resolve C style issues") inverted
the logic on the none elevator comparison.  Fix this and make it
cstyle warning clean.

Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4507
ryao pushed a commit to ClusterHQ/zfs that referenced this issue Jun 7, 2016
@ryao
Fix inverted logic on none elevator comparison
541eac4 
Commit d1d7e26 ("cstyle: Resolve C style issues") inverted
the logic on the none elevator comparison.  Fix this and make it
cstyle warning clean.

Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.5.7
Development

No branches or pull requests
3 participants
@drescherjm @behlendorf @ColinIanKing