Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs test suite: zpool_scrub_002_pos.ksh zpool_scrub_003_pos.ksh #4450

Closed
behlendorf opened this issue Mar 24, 2016 · 0 comments
Closed

zfs test suite: zpool_scrub_002_pos.ksh zpool_scrub_003_pos.ksh #4450

behlendorf opened this issue Mar 24, 2016 · 0 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@behlendorf
Copy link
Contributor

These two test cases appear to be racy and need to be updated so they pass consistently.

Test: /usr/share/zfs/zfs-tests/tests/functional/cli_root/zpool_scrub/zpool_scrub_002_pos (run as root) [00:01] [FAIL]
18:37:37.51 ASSERTION: Verify scrub -s works correctly.
18:37:38.55 SUCCESS: /sbin/zpool scrub testpool.1405
18:37:38.55 cannot cancel scrubbing testpool.1405: there is no active scrub
18:37:38.55 ERROR: /sbin/zpool scrub -s testpool.1405 exited 1
Test: /usr/share/zfs/zfs-tests/tests/functional/cli_root/zpool_scrub/zpool_scrub_003_pos (run as root) [00:02] [FAIL]
18:37:38.56 ASSERTION: scrub command terminates the existing scrub process and starts a new scrub.
18:37:39.81 SUCCESS: /sbin/zpool scrub testpool.1405
18:37:40.96 SUCCESS: /sbin/zpool scrub testpool.1405
18:37:40.96 zpool scrub don't stop existing scrubbing process.
@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Mar 24, 2016
@behlendorf behlendorf mentioned this issue Mar 25, 2016
Closed
behlendorf added a commit to behlendorf/zfs that referenced this issue Mar 26, 2016
@behlendorf
Fix zpool_scrub_* test cases
70005d1 
The zpool_scrub_002 and zpool_scrub_003 test cases fail reliably when
running against fast storage and a small test pool.  This occurs because
the scrub operation itself completes before it can be either cancelled
or restarted.

In order to make this less likely the size of the pool is increased
and the ARC cache is flushed before starting the scrub.

Finally, the setup phase was sped up by minimizing the amount of data
read from /dev/urandom which is slow when reading many gigabytes.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#4450
@behlendorf behlendorf mentioned this issue Mar 26, 2016
Closed
behlendorf added a commit to behlendorf/zfs that referenced this issue Mar 30, 2016
@behlendorf
Fix zpool_scrub_* test cases
9636b6b 
The zpool_scrub_002, zpool_scrub_003, zpool_scrub_004 test cases fail
reliably when running against small pools or fast storage.  This
occurs because the scrub/resilver operation completes before subsequent
commands can be run.

A one second delay has been added to 10% of zio's in order to ensure
the scrub/resilver operation will run for at least several seconds.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#4450
nedbass pushed a commit to nedbass/zfs that referenced this issue Sep 3, 2016
@behlendorf @nedbass
Fix zpool_scrub_* test cases
484a3f6 
The zpool_scrub_002, zpool_scrub_003, zpool_scrub_004 test cases fail
reliably when running against small pools or fast storage.  This
occurs because the scrub/resilver operation completes before subsequent
commands can be run.

A one second delay has been added to 10% of zio's in order to ensure
the scrub/resilver operation will run for at least several seconds.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#4450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@behlendorf