-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a literal colon in a zpool name is allowed, which contradicts the man page #438
Comments
Yes, the man page is incorrect and should be fixed. See zpool_name_valid()->pool_namecheck()->valid_char() in the source. Allowed characters are |
The secondary issue in dracut/ should be reticketed. |
ZoL and all Solaris derivatives allow pool names to contain the colon and space characters. Update the man page to reflect current behavior. Signed-off-by: Brian Behlendorf <[email protected]> Closes: openzfs#438
ZoL and all Solaris derivatives allow pool names to contain the colon and space characters. Update the man page to reflect current behavior. Signed-off-by: Brian Behlendorf <[email protected]> Closes: openzfs#438
As of automake 1.14.2, currently shipped with Ubuntu 14.04, automake warns about AM_INIT_AUTOMAKE having more than one argument: configure.ac:41: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated. For more info, see: configure.ac:41: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation This commit fixes the warnings by following above link's advice, so AM_INIT gets called with the package's name and version. As both are defined in the META file we're parsing it with `grep`, `cut` and `tr`. NOTE: autoconf < 1.14 not supporting m4_esyscmd_s so m4_esyscmd was used and modified `tr` to truncate newlines, too. Signed-off-by: Hajo M<C3><B6>ller <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#438
…aster Merge remote-tracking branch '6.0/stage' into 'master'
The man page says this about
zpool create
:However, a zpool can have a literal colon in its name like this:
Is the man page incorrect?
This is somewhat problematic because the dracut scripts assume that
zfs:
is a safe prefix to use for overloading theroot=
kernel parameter.The text was updated successfully, but these errors were encountered: