Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect default sourcing in the etc/init.d/zfs.lsb.in file. #371

Closed
dajhorn opened this issue Aug 22, 2011 · 0 comments
Closed

Incorrect default sourcing in the etc/init.d/zfs.lsb.in file. #371

dajhorn opened this issue Aug 22, 2011 · 0 comments
Milestone
0.6.0-rc7

Comments

@dajhorn
Copy link
Contributor

dajhorn commented Aug 22, 2011

The etc/init.d/zfs.lsb.in file contains this snippet:

 # Source zfs configuration.
 [ -f /etc/defaults/zfs ] &&  . /etc/defaults/zfs

 RETVAL=0

 LOCKFILE=/var/lock/zfs
 ZFS="@sbindir@/zfs"
 ZPOOL="@sbindir@/zpool"
 ZPOOL_CACHE="@initdir@/zpool.cache"

The /etc/defaults/zfs file should be sourced after variable declarations to allow overrides.

As an aside, my instinct is that allowing an override for a system utility is unsafe. In a cursory search, I cannot find another example of this in distro, or a reason for anything at S-level to be outside of PATH.
@dajhorn dajhorn mentioned this issue Dec 4, 2011
Closed
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Dec 5, 2011
@dajhorn @behlendorf
Source /etc/default/zfs after setting defaults.
c2d9c41 
Let the administrator override all script variables by sourcing the
/etc/default/zfs file after the default values are set.

The spelling mistake in the old path name makes it unlikely that this
bug affected any users.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes: openzfs#371
Rudd-O pushed a commit to Rudd-O/zfs that referenced this issue Feb 1, 2012
@Rudd-O
Source /etc/default/zfs after setting defaults.
e2bcb00 
Let the administrator override all script variables by sourcing the
/etc/default/zfs file after the default values are set.

The spelling mistake in the old path name makes it unlikely that this
bug affected any users.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes: openzfs#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0-rc7
Development

No branches or pull requests
2 participants
@behlendorf @dajhorn