Incorrect ZPOOL_CACHE automake substitution in the init scripts

[dajhorn]

Commit aa2b489 moves the zpool.cache file from /etc/zfs to /etc/init.d like this:

 # etc/init.d/zfs.*.in
 -ZPOOL_CACHE="@sysconfdir@/zfs/zpool.cache"
 +ZPOOL_CACHE="@initdir@/zpool.cache"

Automake sets this default in the top Makefile:

 DEFAULT_INIT_DIR = ${prefix}/etc/init.d

This results in:

 ZPOOL_CACHE="/etc/init.d/zpool.cache"
 ...
 $ZPOOL import -c $ZPOOL_CACHE -aN 2>/dev/null

[behlendorf]

Your of course right. Sorry, I wasn't thinking when I made this change... I'll revert these bits.

As an aside, how do you feel about throwing your init script for ubuntu in with the others? If you'ld rather maintain it yourself that's fine but it might be nice to have them all in one place. For example, the 'zfs share -a' change would have automatically made it in then.

[dajhorn]

I must check whether dh_installinit can use a file produced by an install rule. If yes, then an init script for Ubuntu should be added to the others. (It is unusual that ZFS changes /etc/init.d during an unmanaged installation. None of the major projects in distro do this for a local install.)

The existing init scripts for ZFS have races and dependency cycles in the Ubuntu init stack. I tried a variety of non-invasive fixes, but it looks like patching mountall to recognize ZFS is the best solution. If this happens, then Ubuntu will only need an init.d script for a local install.

[behlendorf]

Yes, having the upstream package provide any real packaging/init scripts/udev rules is a little odd. Typically this is all handled by each downstream distribution since things vary so widely between distributions. Unfortunately, until the package get's an official maintainer for a distribution I feel compelled to provide something.

The existing init scripts for ZFS have races and dependency cycles in the Ubuntu init stack

Issues exactly like this. :)