Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-3.15 feature: renameat2 #2256

Closed
tuxoko opened this issue Apr 14, 2014 · 5 comments
Closed

linux-3.15 feature: renameat2 #2256

tuxoko opened this issue Apr 14, 2014 · 5 comments
Labels
Type: Feature Feature request or new feature

Comments

@tuxoko
Copy link
Contributor

tuxoko commented Apr 14, 2014

linux-3.15 merge window has been closed. It introduced a new syscall renameat2 which does cross rename between two files atomically. This is potentially quite useful, however it needs filesystem support.

I think we might want to implement it, so I open up this feature request issue.
I might try to dig into this myself, however probably not very soon. So feel free to comment if you'd like to pick it up.

Thanks
@behlendorf behlendorf added this to the 0.7.0 milestone Apr 14, 2014
@behlendorf behlendorf removed this from the 0.7.0 milestone Nov 18, 2014
@snajpa snajpa mentioned this issue Oct 15, 2019
Closed
12 tasks
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 17, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
1005377 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 17, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
c413bc9 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 19, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
3df5f60 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
0863c25 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
08955ab 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
531ca2b 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
0053613 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
8fdd887 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 2, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
c2b095c 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug builds
- update configure time tests for rename2 to support kernels from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 5, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
56d7501 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 5, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
db12199 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 5, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
c410b29 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 5, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
2531793 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 6, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
d47376b 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 6, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
da01513 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 6, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
84c3d1f 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 11, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
7d1e69e 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 20, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
e6075d0 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 22, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
12c8bc7 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 23, 2019
@snajpa
zfs_rename: pick up and finish renameat2 flags support
b4d9caf 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Mar 29, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
b91c840 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Apr 6, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
f95b2c5 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
wuxxin pushed a commit to wuxxin/zfs that referenced this issue Apr 23, 2020
@snajpa @wuxxin
zfs_rename: pick up and finish renameat2 flags support
f12d717 
warning: one merge is not sure

Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue May 25, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
5bbbe8e 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Aug 4, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
32bfaa1 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Aug 10, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
8d91e23 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Aug 19, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
49f2b30 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Aug 21, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
a40b227 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Sep 3, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
44497d4 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 11, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
ad676f3 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Oct 12, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
a9f10dc 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 5, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
4fe1268 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 12, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
0c75900 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 15, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
126177d 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 20, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
5a72af3 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Nov 27, 2020
@snajpa
zfs_rename: pick up and finish renameat2 flags support
e105a0b 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Jan 14, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
f8177bf 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Jan 16, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
4950435 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Feb 2, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
f3e39eb 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Apr 27, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
b8ead7e 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Apr 30, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
d834fd6 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Apr 30, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
fc40669 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue Apr 30, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
224d2af 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
snajpa added a commit to vpsfreecz/zfs that referenced this issue May 8, 2021
@snajpa
zfs_rename: pick up and finish renameat2 flags support
fe373db 
Removing new txtypes in favor of compound ZIL operations, see comment in
module/zfs/zfs_log.c.

Other notable changes:

- unlock after the inodes are updated
- pass whiteout znode pointer to zfs_log_rename_whiteout
- don't wrap code directly in ASSERT*(), it turn to noop on non-debug
  builds
- update configure time tests for rename2 to support kernels
  from 3.5 to 4.8

Fixes openzfs#2256
Fixes openzfs#8648
Fixes openzfs#8774

Signed-off-by: Pavel Snajdr <[email protected]>
@haasn
Copy link
Contributor

haasn commented Jun 1, 2021 •
edited
Loading

Hi. Just popping in to point out that openSuSE Tumbleweed currently bricks your system on upgrades if renameat2() fails (and possibly Fedora as well, since that's where they get their scripts from). So clearly, distros except this syscall to work to the extent of not even containing fallback code for it failing.

@cyphar
Copy link
Contributor

cyphar commented Jun 7, 2021

I can revive the PR I originally worked on and was worked on by @snajpa (#9414).

@behlendorf
Copy link
Contributor

@cyphar that would be great. I'm looking forward to it!

@cyphar cyphar mentioned this issue Jun 9, 2021
Closed
13 tasks
@dotlambda dotlambda mentioned this issue Jan 4, 2022
Closed
@BtbN
Copy link
Contributor

BtbN commented Nov 13, 2022

Same as #9414 this can probably be finally closed?
Or is something still missing after 86db35c and dbf6108 ?

@cyphar
Copy link
Contributor

cyphar commented Nov 14, 2022

This can be closed now that #14070 (the final version of the carried PR) has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
5 participants
@tuxoko @behlendorf @BtbN @haasn @cyphar