Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpios Error message regarding chunksize is backward (misleading) #2072

Closed
ghost opened this issue Jan 22, 2014 · 2 comments
Closed

zpios Error message regarding chunksize is backward (misleading) #2072

ghost opened this issue Jan 22, 2014 · 2 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Type: Documentation Indicates a requested change to the documentation
Milestone
0.6.4

Comments

@ghost
Copy link

ghost commented Jan 22, 2014

The error in the zpios man page (issue #2071) would lead you to think that this command line:
zpios -s 1 -c 1m
was for one thread and a 1 MB chunk size. If you run it you get the error message:
Error: in any run chunksize can not be smaller than regionsize.
When you correct the command line based on the correct options (as determined by reading the source code) then you might do this:
zpios -t 1 -s 1m -c 1g
Note that the chunk size is smaller than the regionsize. You get the above error anyway. That is because the error message itself is wrong. It meant to say "in any run chunksize can not be larger than regionsize". If you use the code in the latter fashion then it works fine, so this is just a bug in the error message itself.
@behlendorf
Copy link
Contributor

@uselton It would be great if you could open a pull request which fixes the error message.

@ghost
Copy link
Author

ghost commented Jan 23, 2014

I expect I will, eventually. zpios is on the back burner while I get up to other foolishness.

sikevux added a commit to sikevux/zfs that referenced this issue Jan 24, 2014
@sikevux
Fixed the error message in zpios (issue openzfs#2072)
8362297
sikevux added a commit to sikevux/zfs that referenced this issue Jan 24, 2014
@sikevux
Fixed error with error message from issue openzfs#2072
45ffc05
FransUrbo pushed a commit to FransUrbo/zfs that referenced this issue Feb 5, 2014
@sikevux @FransUrbo
Fix error message in zpios
718c18e 
The chunksize must always be strictly smaller than the regionsize.

Signed-off-by: Andrew Uselton <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#2072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
1 participant
@behlendorf