Command 'zpool list -H' returns error code when there are no pools created

[anushz]

The code is different every time:

root@host1 opt]# zpool list -H
[root@host1 opt]# echo $?
163
[root@host1 opt]# zpool list -H
[root@host1 opt]# echo $?
238
[root@host1 opt]# zpool list -H
[root@host1 opt]# echo $?
188
[root@host1 opt]# zpool list -H
[root@host1 opt]# echo $?
114

With no '-H' option everything works fine:

[root@host1 opt]# zpool list
no pools available
[root@host1 opt]# echo $?
0

As I can see from code the problem seems to be in 'zpool_do_list' function inside 'zfs/cmd/zpool/zpool_main.c'

OS: CentOS 6.4 x86_64
zfs version: 0.6.1

[behlendorf]

Looks like an uninitialized variable, can you version the following trivial patch fixes it.

diff --git a/cmd/zpool/zpool_main.c b/cmd/zpool/zpool_main.c
index 9d4d128..b96fbe4 100644
--- a/cmd/zpool/zpool_main.c
+++ b/cmd/zpool/zpool_main.c
@@ -3059,7 +3059,7 @@ int
 zpool_do_list(int argc, char **argv)
 {
        int c;
-       int ret;
+       int ret = 0;
        list_cbdata_t cb = { 0 };
        static char default_props[] =
            "name,size,allocated,free,capacity,dedupratio,"

[anushz]

Thanks! The patch fixes the issue.

[root@host1 zepostor]# zpool list -H
[root@host1 zepostor]# echo $?
0