Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--with-config=kernel does not generate common.sh for zfs.sh #14027

Closed
ryao opened this issue Oct 13, 2022 · 0 comments · Fixed by #14051
Closed

--with-config=kernel does not generate common.sh for zfs.sh #14027

ryao opened this issue Oct 13, 2022 · 0 comments · Fixed by #14051
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@ryao
Copy link
Contributor

ryao commented Oct 13, 2022

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 20.04
Kernel Version 5.3.0-26-generic
Architecture x86_64
OpenZFS Version master

Describe the problem you're observing

I was working on a kernel bug on a Ubuntu system provided to me by someone else. I had the idea of building only the kernel modules to save time and tried to use the very handy zfs.sh script to load the modules. Unfortunately, building only the kernel module means we do not build common.sh, which is a dependency for zfs.sh. We should build common.sh when we build kernel modules, since zfs.sh depends on it and it can be used for loading them.

Describe how to reproduce the problem

git clean -xdf && ./autogen.sh && ./configure --enable-debug --enable-debuginfo --with-config=kernel && make -j$(nproc)
sudo ./scripts/zfs.sh -v -r
@ryao ryao added the Type: Defect Incorrect behavior (e.g. crash, hang) label Oct 13, 2022
szubersk added a commit to szubersk/zfs that referenced this issue Oct 17, 2022
@szubersk
Process script directory for all configs
f8bff3d 
Fix openzfs#14027
szubersk added a commit to szubersk/zfs that referenced this issue Oct 17, 2022
@szubersk
Process script directory for all configs
3576cae 
Fix openzfs#14027

Signed-off-by: szubersk <[email protected]>
@szubersk szubersk mentioned this issue Oct 17, 2022
Merged
13 tasks
szubersk added a commit to szubersk/zfs that referenced this issue Oct 17, 2022
@szubersk
Process script directory for all configs
427633c 
Fix openzfs#14027

Signed-off-by: szubersk <[email protected]>
szubersk added a commit to szubersk/zfs that referenced this issue Oct 22, 2022
@szubersk
Process script directory for all configs
3aff6ff 
Fix openzfs#14027

Signed-off-by: szubersk <[email protected]>
szubersk added a commit to szubersk/zfs that referenced this issue Oct 23, 2022
@szubersk
Process script directory for all configs
a8bc6d3 
Fix openzfs#14027.

Signed-off-by: szubersk <[email protected]>
behlendorf pushed a commit that referenced this issue Oct 27, 2022
@szubersk
Process script directory for all configs
1428ede 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes #14027
Closes #14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Oct 28, 2022
@szubersk @andrewc12
Process script directory for all configs
380816e 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this issue Oct 30, 2022
@szubersk @shodanshok
Process script directory for all configs
d0edd30 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this issue Nov 3, 2022
@szubersk @shodanshok
Process script directory for all configs
e0f38a0 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
shodanshok pushed a commit to shodanshok/zfs that referenced this issue Nov 3, 2022
@szubersk @shodanshok
Process script directory for all configs
e0efeef 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
9f76ad4 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
2d0d4c8 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
3578599 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
1315e52 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
437beb4 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
f75b1ee 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 9, 2022
@szubersk @andrewc12
Process script directory for all configs
5685827 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 10, 2022
@szubersk @andrewc12
Process script directory for all configs
932f7cd 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
andrewc12 pushed a commit to andrewc12/openzfs that referenced this issue Nov 10, 2022
@szubersk @andrewc12
Process script directory for all configs
ec8bcda 
Even when only building kmods process the scripts directory.  This
way the common.sh script will be generated and the zfs.sh script
can be used to load/unload the in-tree kernel modules.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: szubersk <[email protected]>
Closes openzfs#14027
Closes openzfs#14051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Process script directory for all configs szubersk/zfs
1 participant
@ryao