-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build ZFS 2.1.5 against Linux 5.18.6 #13622
Comments
In the interim, just...don't compile with |
These warnings can be safely ignored and will not result in a build failure unless compiling a debug build with |
To make it possible to build ZFS 2.1.5 against Linux 5.18 we have to disable this specific error condition. Judging from this comment [1] on the ZFS issue tracker, upstream doesn't compile with -Werror at all, so it is safe to disable turning this warning into an error. [1] openzfs/zfs#13622 (comment)
Please keep in mind that since torvalds/linux@3fe617c |
Hello, I'm running Rocky 8.6, with the 5.18 kernel from elrepo and am getting the same error. @rincebrain mentions not to compile with -Werror. I'm not changing any of the compilation flags yet the build still fails with this problem. How do I tell dkms not to build with that flag? |
As @hmenke said, Linux decided that -Werror by default was the correct life choice, in a kernel CONFIG_XYZ option. I believe whenever 2.1.6 gets cut it should have any of the known warnings muted to avoid this problem biting people. There will probably still be issues that only come up in configurations that are not commonly tested that get fixed in a long tail after that release, but most of the issues should be resolved by that, I would hope. |
What is being staged for 2.1.6 can found in the staging branch, https://github.com/openzfs/zfs/tree/zfs-2.1.6-staging. It'd be great if you could give it a try and verify it does in fact resolve all the build warnings. |
@ryao I can confirm that this fixed the attribute warning build errors. Tested with NixOS/nixpkgs@261d8d4 and diff --git a/pkgs/os-specific/linux/zfs/default.nix b/pkgs/os-specific/linux/zfs/default.nix
index eec2d1ad04a..eb8e427a1e0 100644
--- a/pkgs/os-specific/linux/zfs/default.nix
+++ b/pkgs/os-specific/linux/zfs/default.nix
@@ -220,9 +220,10 @@ in {
latestCompatibleLinuxPackages = linuxPackages_5_18;
# this package should point to the latest release.
- version = "2.1.5";
+ version = "2.1.6";
+ rev = "refs/pull/13886/head";
- sha256 = "sha256-a9rmuPO8R8UfxdHvwjfFuYRGn97a1MPmLZRvr3l0swE=";
+ sha256 = "sha256-XEZ1A5u9eHgXLdxo+29EZYwLlEz3x6a+PDL0DDfkMJU=";
};
zfsUnstable = common { |
@hmenke would you mind confirming if the OpenZFS |
@szubersk Yes, it works. See my previous comment: #13622 (comment) |
System information
Describe the problem you're observing
This is a followup issue on #13528.
The build of the kernel module fails with
call to '__write_overflow_field' declared with attribute warning
. This has been resolved in #13575, but that doesn't change the fact that the ZFS release 2.1.5 cannot be built against Linux 5.18.6 despite marking this kernel version as compatible in the META file.Please make a new release that includes the fixes for Linux 5.18. Downstream packagers need point release versions.
Describe how to reproduce the problem
Include any warning/errors/backtraces from the system logs
Build log
The text was updated successfully, but these errors were encountered: