zfs receive does neither support -o property=value nor -x property #1350

maverick1601 · 2013-03-11T20:09:18Z

Receiving ZFS datastreams on Solaris allows properties to be overwritten using -o or ignored using -x, which is useful, e.g. to enable compression on replication servers. This is not supported in ZoL's zfs command.

csiden · 2013-03-11T21:48:00Z

Someone in the FreeBSD community has been working on this and getting review feedback from @ahrens. I'm not sure what the current status is.

Milan-Benes · 2013-09-28T21:22:49Z

Hello, I adapted the said patch from Steven Hartland to compile against ZFSonLinux 0.6.1 and 0.6.2. Minus the manpage, that is. It seems to work well, but certainly a review is in order. Since I'm new to GitHub, I don't know how to include it, so I'm posting a link to it.

behlendorf · 2013-10-11T19:55:08Z

@Milan-Benes This is great thanks! If you could open a pull request with the proposed patch we can get it properly reviewed. This way we'll be sure not to lose track of it.

Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

behlendorf · 2013-11-14T17:50:38Z

I've opened a pull request with the proposed patch against the latest master source so we don't lose this work. But it still needs a good review before it can be merged, it would be great is someone who needs this support could finish up this work.

Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

FransUrbo · 2014-06-10T16:37:30Z

Duplicate of #1050 and #1525.

ahrens · 2014-06-10T17:39:37Z

I updated the pull request (#1867) with my comments. If they belong here, let me know and I will copy/paste.

FransUrbo · 2014-08-04T20:43:44Z

So which of these pull requests (#1050 and #1867) is the correct/best one?

I've tested #1050 for a while and the only problem with that that I found was that it couldn't handle multiple -x.

behlendorf · 2014-08-06T16:36:56Z

#1867 is the most recent but it needs to refreshed based on @ahrens review comments.

Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

…errides Adds support for property overrides (WIP) Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

…errides Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

…xisting snapshots by adding the option "-s" to zfs receive. Signed-off-by: Turbo Fredriksson <[email protected]> Closes: openzfs#2666

…errides Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350 NOTES: Man page updates missing and must be added, see patch: http://blog.multiplay.co.uk/dropzone/freebsd/zfs-recv-properties.patch

Adds support for property overrides (-o property=value), property excludes (-x property) and dataset limits (-l <volume|filesystem>) to zfs receive. Both -o and -x options mirror the functionality already available in Oracle's ZFS implementation which is also mentioned in the upstream feature request openzfs#2745: The -l option allows receive to be limited to specific datasets within the stream effectively allowing partial restores from a multi dataset stream. References: https://www.illumos.org/issues/2745 Ported-by: Milan-Benes Issue openzfs#1350

micw · 2015-08-18T09:38:23Z

I wonder a bit because on my debian wheezy box zfs recv shows:

usage:
    receive [-vnFu] [-d | -e] [-o <property>] ... [-x <property>] ... [-l <filesystem|volume>] ...  <filesystem|volume|snapshot>

For the property list, run: zfs set|get

So I expected that was already included. Today I set up a new box with debian jessie (official zfs build as well, same version: 0.6.4) - and there "-x"/"-o" are missing:

usage:
receive [-vnFu] <filesystem|volume|snapshot>
receive [-vnFu] [-d | -e] <filesystem>

For the property list, run: zfs set|get

Note that the reference to the property list is still there...

FransUrbo · 2015-08-18T09:45:34Z

I wonder a bit because on my debian wheezy box zfs recv shows:

Are you using my debs on that machine? I included the #1867 pull
request in those.
So I expected that was already included. Today I set up a new box with debian jessie (official zfs build as well, same version: 0.6.4) - and there "-x"/"-o" are missing:
What version exactly? Because it should have been included in
the Jessie packages as well.

micw · 2015-08-18T10:13:21Z

Wheezy: zfsutils 0.6.4-1.1-1-wheezy
Jessie: zfsutils 0.6.4-1.2-1

FransUrbo · 2015-08-18T10:28:29Z

Wheezy: zfsutils 0.6.4-1.1-1-wheezy
Jessie: zfsutils 0.6.4-1.2-1

Hmm, that's weird. I have to investigate this. The packaging should be the same, as should the pull requests etc being applied.

chani · 2016-02-04T18:37:22Z

I am not sure where to post this and I am a bit confused due to the several issues for -o and -x here. What is the current state? From my tests neither -x is working nor overriding using -o is with 0.6.5.4 regardless of -p, is that correct?

devZer0 · 2016-10-24T10:50:05Z

i`m also sadly missing this feature

tinuzz · 2016-11-11T13:09:49Z

And to add to the confusion, the official ZoL packages in Debian are also missing this feature, so when you upgrade from ZoL provided 0.6.5.7-8-* to Debian provided 0.6.5.8-1, you face the regression of losing -x / -o support :-(

This allows users to specify "-o property=value" to override and "-x property" to exclude properties when receiving a zfs send stream. Both native and user properties can be specified. This is useful when using zfs send/receive for periodic backup/replication because it lets users change properties such as canmount, mountpoint, or compression without modifying the source. References: https://www.illumos.org/issues/2745 https://www.illumos.org/issues/3753 Reviewed by: Matthew Ahrens <[email protected]> Reviewed-by: Alek Pinchuk <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: loli10K <[email protected]> Closes #1350 Closes #5349

behlendorf mentioned this issue Nov 14, 2013

Adds support for property overrides (WIP) #1867

Closed

behlendorf modified the milestones: 0.7.0, 0.6.5 Jun 11, 2014

behlendorf mentioned this issue Jun 11, 2014

Implement the -o option for "zfs receive" #1525

Closed

FransUrbo mentioned this issue Jul 1, 2014

ZoL is missing the "multi_vdev_crash_dump" feature #2438

Closed

behlendorf mentioned this issue Aug 6, 2014

Request for '-x' option to 'zfs receive'. #1050

Closed

FransUrbo mentioned this issue Sep 5, 2014

"zfs receive" does not have a continue option #2666

Closed

FransUrbo referenced this issue in FransUrbo/zfs Sep 10, 2014

=> openzfs#2668: turbo/issue-2666 - Allow for "zfs receive" to skip e…

8cfa625

…xisting snapshots by adding the option "-s" to zfs receive. Signed-off-by: Turbo Fredriksson <[email protected]> Closes: openzfs#2666

micw mentioned this issue Aug 18, 2015

Option to disable automatic EFI partitioning. #3458

Closed

kernelOfTruth mentioned this issue Jan 29, 2016

zfs recv parameter x not working #4285

Closed

behlendorf removed the Difficulty - Medium label Oct 5, 2016

loli10K mentioned this issue May 3, 2017

Add support for property overrides (-o|-x) in zfs receive #5349

Merged

12 tasks

behlendorf closed this as completed in #5349 May 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zfs receive does neither support -o property=value nor -x property #1350

zfs receive does neither support -o property=value nor -x property #1350

maverick1601 commented Mar 11, 2013

csiden commented Mar 11, 2013

Milan-Benes commented Sep 28, 2013

behlendorf commented Oct 11, 2013

behlendorf commented Nov 14, 2013

FransUrbo commented Jun 10, 2014

ahrens commented Jun 10, 2014

FransUrbo commented Aug 4, 2014

behlendorf commented Aug 6, 2014

micw commented Aug 18, 2015

FransUrbo commented Aug 18, 2015

micw commented Aug 18, 2015

FransUrbo commented Aug 18, 2015

chani commented Feb 4, 2016

devZer0 commented Oct 24, 2016

tinuzz commented Nov 11, 2016

zfs receive does neither support -o property=value nor -x property #1350

zfs receive does neither support -o property=value nor -x property #1350

Comments

maverick1601 commented Mar 11, 2013

csiden commented Mar 11, 2013

Milan-Benes commented Sep 28, 2013

behlendorf commented Oct 11, 2013

behlendorf commented Nov 14, 2013

FransUrbo commented Jun 10, 2014

ahrens commented Jun 10, 2014

FransUrbo commented Aug 4, 2014

behlendorf commented Aug 6, 2014

micw commented Aug 18, 2015

FransUrbo commented Aug 18, 2015

micw commented Aug 18, 2015

FransUrbo commented Aug 18, 2015

chani commented Feb 4, 2016

devZer0 commented Oct 24, 2016

tinuzz commented Nov 11, 2016