Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs recv fails silently when specifying -x encroot, regression against 2.1.2 #13100

Closed
nabijaczleweli opened this issue Feb 14, 2022 · 0 comments
Closed

zfs recv fails silently when specifying -x encroot, regression against 2.1.2 #13100

nabijaczleweli opened this issue Feb 14, 2022 · 0 comments
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@nabijaczleweli
Copy link
Contributor

nabijaczleweli commented Feb 14, 2022 •
edited
Loading

System information

Type Version/Name
Distribution Name Debian
Distribution Version Bullseye
Kernel Version Linux tarta 5.10.0-11-amd64 #1 SMP Debian 5.10.92-1 (2022-01-18) x86_64 GNU/Linux
OpenZFS Version 9f734e8 (current HEAD), against zfs-2.1.2-1.1 (this is also the module version)

Describe the problem you're observing

2.1.2:

# zfs send -RLc dataset@snapshot | zfs recv -x encryption -x encryptionroot -x keylocation -x keyformat -ev tarta-zoot
cannot receive: invalid property 'encryptionroot'

9f734e8:

# zfs send -RLc dataset@snapshot | cmd/zfs/zfs recv -x encryption -x encryptionroot -x keylocation -x keyformat -ev tarta-zoot

(nothing happens, $? nonzero)
@nabijaczleweli nabijaczleweli added the Type: Defect Incorrect behavior (e.g. crash, hang) label Feb 14, 2022
@nabijaczleweli nabijaczleweli changed the title zfs recv fails silently(!) when specifying -x encroot, regression against 2.1.2 zfs recv fails silently when specifying -x encroot, regression against 2.1.2 Feb 14, 2022
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this issue Feb 14, 2022
@nabijaczleweli
libzfs: sendrecv: fix missing error output for invalid properties
90c5fab 
Closes openzfs#13100
Fixes: 7633c0a ("libzfs: sendrecv:
fix unused, remove argsused")
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli nabijaczleweli mentioned this issue Feb 14, 2022
Closed
13 tasks
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: sendrecv: fix missing error output for invalid properties
66a93b1 
Fixes: 7633c0a ("libzfs: sendrecv:
fix unused, remove argsused")

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13100
Closes openzfs#13101
nicman23 pushed a commit to nicman23/zfs that referenced this issue Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: sendrecv: fix missing error output for invalid properties
e5e644f 
Fixes: 7633c0a ("libzfs: sendrecv:
fix unused, remove argsused")

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Amanakis <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13100
Closes openzfs#13101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

zfs-recv.8 fixes, libzfs-sendrecv followup nabijaczleweli/zfs
1 participant
@nabijaczleweli