Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpool create -n summary fails to mention spares specified on the command line #11122

Closed
gdevenyi opened this issue Oct 28, 2020 · 0 comments · Fixed by #11167
Closed

zpool create -n summary fails to mention spares specified on the command line #11122

gdevenyi opened this issue Oct 28, 2020 · 0 comments · Fixed by #11167
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@gdevenyi
Copy link
Contributor

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 20.04.1
Linux Kernel 5.4.0-51-generic
Architecture x86_64
ZFS Version 0.8.5-1
SPL Version 0.8.5-1

Describe the problem you're observing

zpool create -n fails to mention spares in pool summary

Describe how to reproduce the problem

Create a pool such as:
zpool create -n tank raidz2 sda sdb sdc sdd sde spare sdf

Output:

would create 'tank' with the following layout:

        tank
          raidz2
            sda
			sdb
			sdc
			sdd
			sde

The pool summary fails to mention the spares specified on the command line

Include any warning/errors/backtraces from the system logs

NA
@gdevenyi gdevenyi added Status: Triage Needed New issue which needs to be triaged Type: Defect Incorrect behavior (e.g. crash, hang) labels Oct 28, 2020
@behlendorf behlendorf added good first issue Indicates a good issue for first-time contributors and removed Status: Triage Needed New issue which needs to be triaged labels Nov 4, 2020
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this issue Nov 6, 2020
@AttilaFueloep
zpool: Dryrun fails to list some devices
36d8541 
`zpool create -n` fails to list cache and spare vdevs and
`zpool add -n` fails to list spare devices.

Add them to the list.

Signed-off-by: Attila Fülöp <[email protected]>

Closes openzfs#11122
@AttilaFueloep AttilaFueloep mentioned this issue Nov 6, 2020
Merged
12 tasks
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this issue Dec 3, 2020
@AttilaFueloep
zpool: Dryrun fails to list some devices
04fe8b0 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11122
behlendorf pushed a commit that referenced this issue Dec 4, 2020
@AttilaFueloep
zpool: Dryrun fails to list some devices
0cb40fa 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes #11122
Closes #11167
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this issue Dec 23, 2020
@AttilaFueloep
zpool: Dryrun fails to list some devices
e13431b 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11122
Closes openzfs#11167
AttilaFueloep added a commit to AttilaFueloep/zfs that referenced this issue Jan 8, 2021
@AttilaFueloep
zpool: Dryrun fails to list some devices
2f60c8b 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11122
Closes openzfs#11167
behlendorf pushed a commit that referenced this issue Jan 8, 2021
@AttilaFueloep @behlendorf
zpool: Dryrun fails to list some devices
6539bf7 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes #11122
Closes #11167
jsai20 pushed a commit to jsai20/zfs that referenced this issue Mar 30, 2021
@AttilaFueloep @jsai20
zpool: Dryrun fails to list some devices
6a20d13 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11122
Closes openzfs#11167
sempervictus pushed a commit to sempervictus/zfs that referenced this issue May 31, 2021
@AttilaFueloep
zpool: Dryrun fails to list some devices
c2c36db 
`zpool create -n` fails to list cache and spare vdevs.
`zpool add -n` fails to list spare devices.
`zpool split -n` fails to list `special` and `dedup` labels.
`zpool add -n` and `zpool split -n` shouldn't list hole devices.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Attila Fülöp <[email protected]>
Closes openzfs#11122
Closes openzfs#11167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Indicates a good issue for first-time contributors Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

zpool: Dryrun fails to list some devices AttilaFueloep/zfs
2 participants
@behlendorf @gdevenyi