-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZFS send dedup multi-thread #1112
Comments
Multithreading might not help as much as you think. A known issue when doing There is a neat program called mbuffer that allows you to create an additional buffer of a size that you specify. If you were to use it on the |
This is a very naive comment, but couldn't we simply bump the size of that buffer to something larger then most TCP window sizes over say, 10 GbE ethernet, and call it a day as a simple fix? |
Instead of mbuffer an option is to use pv as it is both in existing Linux
|
'zfs receive' can stall for more than a few seconds while it does a bunch of reads on its local disks, especially for incremental receive jobs. mbuffer, with a default buffer size of over 80 megabytes, makes a lot of sense especially over relatively slow (eg: 100 megabit) networks. TCP buffers alone is not a good idea. |
If I recall correctly, mbuffer's default buffer size is 2MB. As for increasing the buffer size, the buffer is in your shell (e.g. bash), so it is not something that we can control unless we add another buffer. That is what mbuffer does. |
5c3f61e implemented a larger receive buffer. |
b738bc5 also significantly improved performance by improving the prefetch. |
…ct_agent (openzfs#1112) build(deps): bump anstyle-wincon in /cmd/zfs_object_agent Bumps [anstyle-wincon](https://github.com/rust-cli/anstyle) from 1.0.1 to 1.0.2. - [Commits](rust-cli/anstyle@anstyle-wincon-v1.0.1...anstyle-wincon-v1.0.2) --- updated-dependencies: - dependency-name: anstyle-wincon dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hi,
the "zfs send -vD" is dedup of the stream which is performing very badly. I figured it uses just one core of a multi-core system. So if we have a 28 core machine we wouldn't see any improvement.
Therefore, the feature request to make zfs send dedup multi-threaded.
Best.
The text was updated successfully, but these errors were encountered: