Fix data corruption when cloning embedded blocks

Don't overwrite blk_phys_birth, as for embedded blocks it is part of the payload. Reviewed-by: Richard Yao <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Issue #13392 Closes #14739
openzfs · Apr 12, 2023 · c71fe71 · c71fe71
1 parent 6e01593
commit c71fe71
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/module/zfs/dmu.c b/module/zfs/dmu.c
@@ -2312,8 +2312,10 @@ dmu_brt_clone(objset_t *os, uint64_t object, uint64_t offset, uint64_t length,
 			dl->dr_overridden_by.blk_phys_birth = 0;
 		} else {
 			dl->dr_overridden_by.blk_birth = dr->dr_txg;
-			dl->dr_overridden_by.blk_phys_birth =
-			    BP_PHYSICAL_BIRTH(bp);
+			if (!BP_IS_EMBEDDED(bp)) {
+				dl->dr_overridden_by.blk_phys_birth =
+				    BP_PHYSICAL_BIRTH(bp);
+			}
 		}
 
 		mutex_exit(&db->db_mtx);