Skip to content

Commit

Permalink
scripts/enum-extract.pl should not hard code perl path
Browse files Browse the repository at this point in the history
This is a portability issue. The issue had already been fixed for
scripts/cstyle.pl by 2dbf1bf.
scripts/enum-extract.pl was added to the repository the following year
without this portability fix.

Michael Bishop informed me that this broke his attempt to build ZFS
2.1.6 on NixOS, since he was building manually outside of their package
manager (that usually rewrites the shebangs to NixOS' unusual paths).
NixOS puts all of the paths into $PATH, so scripts that portably rely
on env to find the interpreter still work.

Reviewed-by: Tino Reichardt <[email protected]> 
Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes #14012
  • Loading branch information
ryao authored Oct 11, 2022
1 parent ed566bf commit bfaa1d9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/enum-extract.pl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/perl -w
#!/usr/bin/env perl

my $usage = <<EOT;
usage: config-enum enum [file ...]
Expand Down

0 comments on commit bfaa1d9

Please sign in to comment.