Skip to content

Commit

Permalink
Remove hard-coded 80 column output
Browse files Browse the repository at this point in the history
When stdout is detected to be a tty use the number of columns
specified by the terminal.  If that fails fall back to a default
80 column width.  In the non-tty case allow for 999 column lines.

Signed-off-by: Brian Behlendorf <[email protected]>
  • Loading branch information
craig-sanders authored and behlendorf committed Mar 27, 2012
1 parent 2008ab8 commit 9fc6070
Showing 1 changed file with 25 additions and 4 deletions.
29 changes: 25 additions & 4 deletions cmd/zpool/zpool_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2175,11 +2175,30 @@ print_iostat(zpool_handle_t *zhp, void *data)
return (0);
}

static int
get_columns(void)
{
struct winsize ws;
int columns = 80;
int error;

if (isatty(STDOUT_FILENO)) {
error = ioctl(STDOUT_FILENO, TIOCGWINSZ, &ws);
if (error == 0)
columns = ws.ws_col;
} else {
columns = 999;
}

return columns;
}

int
get_namewidth(zpool_handle_t *zhp, void *data)
{
iostat_cbdata_t *cb = data;
nvlist_t *config, *nvroot;
int columns;

if ((config = zpool_get_config(zhp, NULL)) != NULL) {
verify(nvlist_lookup_nvlist(config, ZPOOL_CONFIG_VDEV_TREE,
Expand All @@ -2191,13 +2210,15 @@ get_namewidth(zpool_handle_t *zhp, void *data)
}

/*
* The width must fall into the range [10,38]. The upper limit is the
* maximum we can have and still fit in 80 columns.
* The width must be at least 10, but may be as large as the
* column width - 42 so that we can still fit in one line.
*/
columns = get_columns();

if (cb->cb_namewidth < 10)
cb->cb_namewidth = 10;
if (cb->cb_namewidth > 38)
cb->cb_namewidth = 38;
if (cb->cb_namewidth > columns - 42)
cb->cb_namewidth = columns - 42;

return (0);
}
Expand Down

0 comments on commit 9fc6070

Please sign in to comment.