Skip to content

Commit

Permalink
Enable PF_FSTRANS for ioctl secpolicy callbacks
Browse files Browse the repository at this point in the history
At the very least, the zfs_secpolicy_write_perms ioctl security policy
callback, which calls dsl_dataset_hold(), can require freeing memory and,
therefore, re-enter ZFS.  This patch enables PF_FSTRANS for all of the
security policy callbacks similarly to the manner in which it's enabled
for the actual ioctl callback.

May-fix: #4554
  • Loading branch information
dweeezil committed Apr 24, 2016
1 parent da5e151 commit 8f80c0a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion module/zfs/zfs_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -5831,8 +5831,11 @@ zfsdev_ioctl(struct file *filp, unsigned cmd, unsigned long arg)
}


if (error == 0 && !(flag & FKIOCTL))
if (error == 0 && !(flag & FKIOCTL)) {
cookie = spl_fstrans_mark();
error = vec->zvec_secpolicy(zc, innvl, CRED());
spl_fstrans_unmark(cookie);
}

if (error != 0)
goto out;
Expand Down

0 comments on commit 8f80c0a

Please sign in to comment.