-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
zfs allow
and zfs unallow
support
ZFS allows for specific permissions to be delegated to normal users with the `zfs allow` and `zfs unallow` commands. In addition, non- privileged users should be able to run all of the follow commands: * zpool [list | iostat | status | get] * zfs [list | get] Historically this functionality was unavailable on Linux. In order to add it the secpolicy_* functions need to be implemented and mapped to the equivalent Linux capability. Only then could the permissions on the `/dev/zfs` be related and the internal ZFS permission checks used. Even with this change some limitations remain. Under Linux only the root user is allowed to modify the namespace (unless it's a private namespace). This means the mount, mountpoint, canmount, unmount, and remount delegations cannot be supported with the existing code. It may be possible to add this functionality in the future. This functionality was validated with the cli_user and delegation test cases from the ZFS Test Suite. These tests exhaustively verify each of the supported permissions which can be delegated and ensures only an authorized user can perform it. Two minor bug fixes were required for test-running.py. First, the Timer() object cannot be safely created in a `try:` block when there is an unconditional `finally` block which references it. Second, when running as a normal user also check for scripts using the both the .ksh and .sh suffixes. Finally, existing users who are simulating delegations by setting group permissions on the /dev/zfs device can revert that customization when this change is applied. Signed-off-by: Brian Behlendorf <[email protected]> Issue #362
- Loading branch information
1 parent
26ef0cc
commit 8ee9b1c
Showing
75 changed files
with
670 additions
and
213 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* CDDL HEADER START | ||
* | ||
* The contents of this file are subject to the terms of the | ||
* Common Development and Distribution License (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* | ||
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE | ||
* or http://www.opensolaris.org/os/licensing. | ||
* See the License for the specific language governing permissions | ||
* and limitations under the License. | ||
* | ||
* When distributing Covered Code, include this CDDL HEADER in each | ||
* file and include the License file at usr/src/OPENSOLARIS.LICENSE. | ||
* If applicable, add the following below this CDDL HEADER, with the | ||
* fields enclosed by brackets "[]" replaced with your own identifying | ||
* information: Portions Copyright [yyyy] [name of copyright owner] | ||
* | ||
* CDDL HEADER END | ||
*/ | ||
|
||
/* | ||
* Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved. | ||
* Copyright 2015, Joyent, Inc. All rights reserved. | ||
* Copyright (c) 2016, Lawrence Livermore National Security, LLC. | ||
*/ | ||
|
||
#ifndef _SYS_POLICY_H | ||
#define _SYS_POLICY_H | ||
|
||
#ifdef _KERNEL | ||
|
||
#include <sys/cred.h> | ||
#include <sys/types.h> | ||
#include <sys/xvattr.h> | ||
#include <sys/zpl.h> | ||
|
||
int secpolicy_nfs(const cred_t *); | ||
int secpolicy_sys_config(const cred_t *, boolean_t); | ||
int secpolicy_vnode_access2(const cred_t *, struct inode *, | ||
uid_t, mode_t, mode_t); | ||
int secpolicy_vnode_any_access(const cred_t *, struct inode *, uid_t); | ||
int secpolicy_vnode_chown(const cred_t *, uid_t); | ||
int secpolicy_vnode_create_gid(const cred_t *); | ||
int secpolicy_vnode_remove(const cred_t *); | ||
int secpolicy_vnode_setdac(const cred_t *, uid_t); | ||
int secpolicy_vnode_setid_retain(const cred_t *, boolean_t); | ||
int secpolicy_vnode_setids_setgids(const cred_t *, gid_t); | ||
int secpolicy_zinject(const cred_t *); | ||
int secpolicy_zfs(const cred_t *); | ||
void secpolicy_setid_clear(vattr_t *, cred_t *); | ||
int secpolicy_setid_setsticky_clear(struct inode *, vattr_t *, | ||
const vattr_t *, cred_t *); | ||
int secpolicy_xvattr(xvattr_t *, uid_t, cred_t *, vtype_t); | ||
int secpolicy_vnode_setattr(cred_t *, struct inode *, struct vattr *, | ||
const struct vattr *, int, int (void *, int, cred_t *), void *); | ||
int secpolicy_basic_link(const cred_t *); | ||
|
||
#endif /* _KERNEL */ | ||
#endif /* _SYS_POLICY_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.