Skip to content

Commit

Permalink
Revert "Fix __zio_execute() asynchronous dispatch"
Browse files Browse the repository at this point in the history
This reverts commit 9157970 which
limited the asynchronous dispatch to kernel space.  We want to do
this for two reasons:

1) While we have slightly more headroom in user space excessively
   deep stacks have been observed while running ztest, see #2293.

2) Removing this conditional makes the pipeline behave consistently
   regardless of if it's executing in kernel space or user space.
   This way we're more likely to uncover subtle issues with ztest.

Signed-off-by: Richard Yao <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #2384
  • Loading branch information
behlendorf committed Jun 11, 2014
1 parent 0f62934 commit 7f6884f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions module/zfs/zio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1342,7 +1342,6 @@ __zio_execute(zio_t *zio)
return;
}

#ifdef _KERNEL
/*
* If we executing in the context of the tx_sync_thread,
* or we are performing pool initialization outside of a
Expand All @@ -1357,7 +1356,6 @@ __zio_execute(zio_t *zio)
zio_taskq_dispatch(zio, ZIO_TASKQ_ISSUE, cut);
return;
}
#endif

zio->io_stage = stage;
rv = zio_pipeline[highbit(stage) - 1](zio);
Expand Down

0 comments on commit 7f6884f

Please sign in to comment.