Skip to content

Commit

Permalink
tests: fix cosmetic permission issues during make install
Browse files Browse the repository at this point in the history
files in dist_*_SCRIPTS get installed with 0755, those in dist_*_DATA
with 0644. This commit moves all .kshlib, .shlib and .cfg files in the
testsuite to dist_pkgdata_DATA, and removes the shebang from
zpool_import.kshlib.

This ensures that the files are installed with appropriate permissions
and silences some warnings from lintian

Signed-off-by: Stoiko Ivanov <[email protected]>
  • Loading branch information
Stoiko Ivanov committed May 23, 2019
1 parent 7a294cb commit 78c28f4
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 8 deletions.
6 changes: 4 additions & 2 deletions tests/zfs-tests/tests/functional/alloc_class/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
pkgdatadir = $(datadir)/@PACKAGE@/zfs-tests/tests/functional/alloc_class
dist_pkgdata_SCRIPTS = \
alloc_class.cfg \
alloc_class.kshlib \
setup.ksh \
cleanup.ksh \
alloc_class_001_pos.ksh \
Expand All @@ -17,3 +15,7 @@ dist_pkgdata_SCRIPTS = \
alloc_class_011_neg.ksh \
alloc_class_012_pos.ksh \
alloc_class_013_pos.ksh

dist_pkgdata_DATA = \
alloc_class.cfg \
alloc_class.kshlib
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#!/bin/ksh

#
# This file and its contents are supplied under the terms of the
# Common Development and Distribution License ("CDDL"), version 1.0.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ dist_pkgdata_SCRIPTS = \
cleanup.ksh \
zpool_initialize_attach_detach_add_remove.ksh \
zpool_initialize_import_export.ksh \
zpool_initialize.kshlib \
zpool_initialize_offline_export_import_online.ksh \
zpool_initialize_online_offline.ksh \
zpool_initialize_split.ksh \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ pkgdatadir = $(datadir)/@PACKAGE@/zfs-tests/tests/functional/cli_root/zpool_trim
dist_pkgdata_SCRIPTS = \
setup.ksh \
cleanup.ksh \
zpool_trim.kshlib \
zpool_trim_attach_detach_add_remove.ksh \
zpool_trim_import_export.ksh \
zpool_trim_multiple.ksh \
Expand All @@ -20,3 +19,6 @@ dist_pkgdata_SCRIPTS = \
zpool_trim_unsupported_vdevs.ksh \
zpool_trim_verify_checksums.ksh \
zpool_trim_verify_trimmed.ksh

dist_pkgdata_DATA = \
zpool_trim.kshlib
5 changes: 4 additions & 1 deletion tests/zfs-tests/tests/functional/removal/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ dist_pkgdata_SCRIPTS = \
removal_with_send.ksh removal_with_send_recv.ksh \
removal_with_snapshot.ksh removal_with_write.ksh \
removal_with_zdb.ksh remove_mirror.ksh remove_mirror_sanity.ksh \
remove_raidz.ksh remove_expanded.ksh removal.kshlib
remove_raidz.ksh remove_expanded.ksh

dist_pkgdata_DATA = \
removal.kshlib

pkgexecdir = $(datadir)/@PACKAGE@/zfs-tests/tests/functional/removal
2 changes: 1 addition & 1 deletion tests/zfs-tests/tests/perf/Makefile.am
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
pkgdatadir = $(datadir)/@PACKAGE@/zfs-tests/tests/perf
dist_pkgdata_SCRIPTS = \
dist_pkgdata_DATA = \
nfs-sample.cfg \
perf.shlib

Expand Down

0 comments on commit 78c28f4

Please sign in to comment.