Skip to content

Commit

Permalink
ZTS: tst.terminate_by_signal increase test threshold
Browse files Browse the repository at this point in the history
The tst.terminate_by_signal test case may occasionally fail when
running in a less consistent virtual environment.  For all observed
failures the process was terminated correctly but it took longer than
expected resulting in too many snapshot being created.

To minimize the likelyhood of this occuring increase the threshold
from 50 to 90 snapshots.  The larger limit will still verifiy that
the channel program was correctly terminated early.

Reviewed-by: Don Brady <[email protected]>
Reviewed-by: Reviewed-by: Kjeld Schouten <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #9601
  • Loading branch information
behlendorf authored and tonyhutter committed Jan 22, 2020
1 parent e688774 commit 6fed191
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ log_note "$snap_count snapshots created by ZCP"

if [ "$snap_count" -eq 0 ]; then
log_fail "Channel program failed to run."
elif [ "$snap_count" -gt 50 ]; then
elif [ "$snap_count" -gt 90 ]; then
log_fail "Too many snapshots after a cancel ($snap_count)."
else
log_pass "Canceling a long-running channel program works."
Expand Down

0 comments on commit 6fed191

Please sign in to comment.