Redacted Send/Receive causes zdb to dump core

When used with verbosity >= 4 zdb fails an assertion in dump_bookmarks() because it expects snprintf() to retun 0 on success. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Paul Dagnelie <[email protected]> Signed-off-by: loli10K <[email protected]> Closes #8948
openzfs · Jun 25, 2019 · 5279ae9 · 5279ae9
1 parent 746d4a4
commit 5279ae9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cmd/zdb/zdb.c b/cmd/zdb/zdb.c
@@ -1939,7 +1939,7 @@ dump_bookmarks(objset_t *os, int verbosity)
 		char osname[ZFS_MAX_DATASET_NAME_LEN];
 		char buf[ZFS_MAX_DATASET_NAME_LEN];
 		dmu_objset_name(os, osname);
-		VERIFY0(snprintf(buf, sizeof (buf), "%s#%s", osname,
+		VERIFY3S(0, <=, snprintf(buf, sizeof (buf), "%s#%s", osname,
 		    attr.za_name));
 		(void) dump_bookmark(dp, buf, verbosity >= 5, verbosity >= 6);
 	}