Skip to content

Commit

Permalink
Set zvol_major/zvol_threads permissions
Browse files Browse the repository at this point in the history
The zvol_major and zvol_threads module options were being created
with 0 permission bits.  This prevented them from being listed in
the /sys/module/zfs/parameters/ directory, although they were
visible in `modinfo zfs`.  This patch fixes the issue by updating
the permission bits to 0444.  For the moment these options must
be read-only because they are used during module initialization.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue #392
  • Loading branch information
behlendorf committed Dec 7, 2011
1 parent 23bdb07 commit 30a9524
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions module/zfs/zvol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1350,8 +1350,8 @@ zvol_fini(void)
list_destroy(&zvol_state_list);
}

module_param(zvol_major, uint, 0);
module_param(zvol_major, uint, 0444);
MODULE_PARM_DESC(zvol_major, "Major number for zvol device");

module_param(zvol_threads, uint, 0);
module_param(zvol_threads, uint, 0444);
MODULE_PARM_DESC(zvol_threads, "Number of threads for zvol device");

0 comments on commit 30a9524

Please sign in to comment.