Skip to content

Commit

Permalink
Sort log spacemap tunables in alphabetical order
Browse files Browse the repository at this point in the history
Beside the whole commit being a nit in reality it should
bring the diffs of the spa_log_spacemap.c source file
between ZoL and delphix/zfs to 0.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Chris Dunlop <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Serapheim Dimitropoulos <[email protected]>
Closes #9143
  • Loading branch information
sdimitro authored and behlendorf committed Aug 12, 2019
1 parent c81f179 commit 2081db7
Showing 1 changed file with 32 additions and 32 deletions.
64 changes: 32 additions & 32 deletions module/zfs/spa_log_spacemap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1283,26 +1283,24 @@ spa_ld_log_spacemaps(spa_t *spa)

#if defined(_KERNEL)
/* BEGIN CSTYLED */
module_param(zfs_unflushed_max_mem_amt, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_max_mem_amt,
"Specific hard-limit in memory that ZFS allows to be used for "
"unflushed changes");
module_param(zfs_keep_log_spacemaps_at_export, int, 0644);
MODULE_PARM_DESC(zfs_keep_log_spacemaps_at_export,
"Prevent the log spacemaps from being flushed and destroyed "
"during pool export/destroy");

module_param(zfs_unflushed_max_mem_ppm, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_max_mem_ppm,
"Percentage of the overall system memory that ZFS allows to be "
"used for unflushed changes (value is calculated over 1000000 for "
"finer granularity");
module_param(zfs_max_logsm_summary_length, ulong, 0644);
MODULE_PARM_DESC(zfs_max_logsm_summary_length,
"Maximum number of rows allowed in the summary of "
"the spacemap log");

module_param(zfs_unflushed_log_block_max, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_log_block_max,
"Hard limit (upper-bound) in the size of the space map log "
"in terms of blocks.");
module_param(zfs_max_log_walking, ulong, 0644);
MODULE_PARM_DESC(zfs_max_log_walking,
"The number of past TXGs that the flushing algorithm of the log "
"spacemap feature uses to estimate incoming log blocks");

module_param(zfs_unflushed_log_block_min, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_log_block_min,
"Lower-bound limit for the maximum amount of blocks allowed in "
"log spacemap (see zfs_unflushed_log_block_max)");
module_param(zfs_min_metaslabs_to_flush, ulong, 0644);
MODULE_PARM_DESC(zfs_min_metaslabs_to_flush,
"Minimum number of metaslabs to flush per dirty TXG");

module_param(zfs_unflushed_log_block_pct, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_log_block_pct,
Expand All @@ -1312,23 +1310,25 @@ MODULE_PARM_DESC(zfs_unflushed_log_block_pct,
" number of log blocks is capped at 4 times the number of "
"metaslabs)");

module_param(zfs_max_log_walking, ulong, 0644);
MODULE_PARM_DESC(zfs_max_log_walking,
"The number of past TXGs that the flushing algorithm of the log "
"spacemap feature uses to estimate incoming log blocks");
module_param(zfs_unflushed_log_block_max, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_log_block_max,
"Hard limit (upper-bound) in the size of the space map log "
"in terms of blocks.");

module_param(zfs_max_logsm_summary_length, ulong, 0644);
MODULE_PARM_DESC(zfs_max_logsm_summary_length,
"Maximum number of rows allowed in the summary of "
"the spacemap log");
module_param(zfs_unflushed_log_block_min, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_log_block_min,
"Lower-bound limit for the maximum amount of blocks in "
"log spacemap.");

module_param(zfs_min_metaslabs_to_flush, ulong, 0644);
MODULE_PARM_DESC(zfs_min_metaslabs_to_flush,
"Minimum number of metaslabs to flush per dirty TXG");
module_param(zfs_unflushed_max_mem_amt, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_max_mem_amt,
"Specific hard-limit in memory that ZFS allows to be used for "
"unflushed changes");

module_param(zfs_keep_log_spacemaps_at_export, int, 0644);
MODULE_PARM_DESC(zfs_keep_log_spacemaps_at_export,
"Prevent the log spacemaps from being flushed and destroyed "
"during pool export/destroy");
module_param(zfs_unflushed_max_mem_ppm, ulong, 0644);
MODULE_PARM_DESC(zfs_unflushed_max_mem_ppm,
"Percentage of the overall system memory that ZFS allows to be "
"used for unflushed changes (value is calculated over 1000000 for "
"finer granularity");
/* END CSTYLED */
#endif

0 comments on commit 2081db7

Please sign in to comment.