Don't fail to umask for O_TMPFILE files

Update ->i_mode with umask for O_TMPFILE files. (Note that zpl_init_acl() will return 0 without `ip->i_mode &= ~current_umask();` if not POSIX ACL.) Signed-off-by: Tomohiro Kusumi <[email protected]>
openzfs · Jul 7, 2019 · 104b9d2 · 104b9d2
1 parent 1086f54
commit 104b9d2
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/module/zfs/zpl_inode.c b/module/zfs/zpl_inode.c
@@ -231,6 +231,7 @@ zpl_tmpfile(struct inode *dir, struct dentry *dentry, zpl_umode_t mode)
 	cookie = spl_fstrans_mark();
 	error = -zfs_tmpfile(dir, vap, 0, mode, &ip, cr, 0, NULL);
 	if (error == 0) {
+		ip->i_mode &= ~current_umask();
 		/* d_tmpfile will do drop_nlink, so we should set it first */
 		set_nlink(ip, 1);
 		d_tmpfile(dentry, ip);