This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Linux 4.14 compat: vfs_read/vfs_write => kernel_read/kernel_write #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
kernel_read/kernel_write have always wrapped vfs_read/vfs_write, respectively, with a safety net around casting to user pointers too. kernel_read was always exported, going back to Linux's very first git check-in. kernel_write was exported in 3.9. Linux 4.14 unexported vfs_read & vfs_write, after replacing all modular calls to these functions with kernel_read & kernel_write, respectively. Linux 4.14 also changed the signatures of kernel_read & kernel_write to more closely match vfs_read & vfs_write. Signed-off-by: Pritam Baral <[email protected]>
8 tasks
|
This patch works ok on my install. I can mount files on older kernels. |
|
Replaced by #667. @pritambaral thanks for refreshing this, I've taken your updated version and reworked it to be more strict about the prototypes. Can you please look it over. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
Closes #659 (the author of which excused himself from working on it)
This also incorporates some of the feedback on #659.
Dummy PR against ZFS to run automated tests: openzfs/zfs#6861