Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Allow larger SPA names in stats #641

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Conversation

gaurkuma
Copy link
Contributor

@gaurkuma gaurkuma commented Aug 8, 2017

Signed-off-by: gaurkuma [email protected]

ZFS changes Pull Request: openzfs/zfs#6481

@behlendorf behlendorf merged commit 9df9692 into openzfs:master Aug 11, 2017
@richardelling
Copy link
Contributor

For the archives: in illumos a method for storing long strings was added in commit 0e96d867a045da50bf7e014cab94cb44528a0f5 in July 2015. The method is described thusly,

 *      KSTAT_FLAG_LONGSTRINGS:
 *
 *              Indicates that this kstat contains long strings (which
 *              are stored outside of the kstat data section). When copied
 *              out to user space the string data will be held in the data
 *              section provided by the user.

As you can imagine, this is a PITA to use because you have to manage the string's location in-kernel. Specifically, remember when changing it's allocation to also update the kstat's pointer. Also, for SPL specifically, the user code would need to be ported.

The solution implemented here is much simpler and less error-prone for future developers.

For some historical perspective, there was a time when Solaris ran on a workstation with 4MB of RAM. Every byte was precious. Thankfully, those days are long gone.

tonyhutter pushed a commit to tonyhutter/spl that referenced this pull request Mar 6, 2018
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: gaurkuma <[email protected]>
Closes openzfs#641
tonyhutter pushed a commit that referenced this pull request Mar 19, 2018
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Giuseppe Di Natale <[email protected]>
Signed-off-by: gaurkuma <[email protected]>
Closes #641
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants