This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Module parameter to enable spl_panic() to panic the kernel #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In unattended operations it's often more useful to have node panic and reboot when it encounters problems as opposed to sit there indefinitely waiting for somebody to discover it. This implements an spl_panic_crash module parameter, set it to nonzero to cause spl_panic() to call panic(). Signed-off-by: Oleg Drokin <[email protected]>
|
I've found myself wanting this for a while now, and i've always resorted to patching |
|
Does this cover all instances where zfs/spl would panic, or just the spl ones? I've come across instances where zfs panicked and the system kept running (sometimes without available pool io) until I hard rebooted. eg openzfs/zfs#6315 |
|
This covers all cases where spl_panic() is called via various assertions. ZFS assertions are still done via spl I am sure. |
dinatale2
approved these changes
Jul 26, 2017
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unattended operations it's often more useful to have node
panic and reboot when it encounters problems as opposed to
sit there indefinitely waiting for somebody to discover it.
This implements an spl_panic_crash module parameter, set it
to nonzero to cause spl_panic() to call panic().
Signed-off-by: Oleg Drokin [email protected]