This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
glibc 2.25 compat: remove assert(X=Y) #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assert() related definitions in glibc 2.25 were altered to warn about assert(X=Y) when -Wparentheses is used. See https://abi-laboratory.pro/tracker/changelog/glibc/2.25/log.html lib/list.c used this construct to set the value of a magic field which is defined only when debugging. Replaced the assert()s with #ifndef/#endifs. Signed-off-by: Olaf Faaland <[email protected]>
|
This was detected building on arch, which as of about 2 weeks ago was using glibc 2.25. The build fails due to -Wparentheses being promoted to an error. Tested with |
behlendorf
approved these changes
Apr 3, 2017
tonyhutter
pushed a commit
to tonyhutter/spl
that referenced
this pull request
May 23, 2017
The assert() related definitions in glibc 2.25 were altered to warn about assert(X=Y) when -Wparentheses is used. See https://abi-laboratory.pro/tracker/changelog/glibc/2.25/log.html lib/list.c used this construct to set the value of a magic field which is defined only when debugging. Replaced the assert()s with #ifndef/#endifs. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Olaf Faaland <[email protected]> Closes openzfs#610
tonyhutter
pushed a commit
that referenced
this pull request
Jun 9, 2017
The assert() related definitions in glibc 2.25 were altered to warn about assert(X=Y) when -Wparentheses is used. See https://abi-laboratory.pro/tracker/changelog/glibc/2.25/log.html lib/list.c used this construct to set the value of a magic field which is defined only when debugging. Replaced the assert()s with #ifndef/#endifs. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Olaf Faaland <[email protected]> Closes #610
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert() related definitions in glibc 2.25 were altered to warn
about assert(X=Y) when -Wparentheses is used. See
https://abi-laboratory.pro/tracker/changelog/glibc/2.25/log.html
lib/list.c used this construct to set the value of a magic field which
is defined only when debugging.
Replaced the assert()s with #ifndef/#endifs.
Signed-off-by: Olaf Faaland [email protected]